Re: [Qemu-devel] [PATCH v6 2/7] qemu.py: fix is_running() return before first launch()

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

On Mon, Jul 31, 2017 at 10:51:05AM +0200, Amador Pahim wrote:
> is_running() returns None when called before the first time we
> call launch():
> 
>     >>> import qemu
>     >>> vm = qemu.QEMUMachine('qemu-system-x86_64')
>     >>> vm.is_running()
>     >>>
> 
> It should retunt False instead. This patch fixes that.

s/retunt/return/

> 
> Signed-off-by: Amador Pahim <apahim@redhat.com>
> ---
>  scripts/qemu.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index 2f1984c93c..77565eb092 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -86,7 +86,7 @@ class QEMUMachine(object):
>              raise
>  
>      def is_running(self):
> -        return self._popen and (self._popen.poll() is None)
> +        return self._popen is not None and (self._popen.poll() is None)

The parentheses are inconsistent:

  return (self._popen is not None) and (self._popen.poll() is None)

An alternative:

  return bool(self._popen and self._popen.poll())

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]