From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
"Daniel P. Berrange" <berrange@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL 1/9] trace: ensure .stp files are rebuilt if trace tool source changes
Date: Tue, 1 Aug 2017 14:16:10 +0100 [thread overview]
Message-ID: <20170801131618.27332-2-stefanha@redhat.com> (raw)
In-Reply-To: <20170801131618.27332-1-stefanha@redhat.com>
From: "Daniel P. Berrange" <berrange@redhat.com>
The make rules for generating the .stp files forgot to add a dep
on $(tracetool-y) to trigger a rebuild if the trace tool source
changes.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-id: 20170728133631.5449-1-berrange@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
Makefile.target | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Makefile.target b/Makefile.target
index 2baec9252f..7f42c45db8 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -48,7 +48,10 @@ else
TARGET_TYPE=system
endif
-$(QEMU_PROG).stp-installed: $(BUILD_DIR)/trace-events-all
+tracetool-y = $(SRC_PATH)/scripts/tracetool.py
+tracetool-y += $(shell find $(SRC_PATH)/scripts/tracetool -name "*.py")
+
+$(QEMU_PROG).stp-installed: $(BUILD_DIR)/trace-events-all $(tracetool-y)
$(call quiet-command,$(TRACETOOL) \
--group=all \
--format=stap \
@@ -58,7 +61,7 @@ $(QEMU_PROG).stp-installed: $(BUILD_DIR)/trace-events-all
--target-type=$(TARGET_TYPE) \
$< > $@,"GEN","$(TARGET_DIR)$(QEMU_PROG).stp-installed")
-$(QEMU_PROG).stp: $(BUILD_DIR)/trace-events-all
+$(QEMU_PROG).stp: $(BUILD_DIR)/trace-events-all $(tracetool-y)
$(call quiet-command,$(TRACETOOL) \
--group=all \
--format=stap \
@@ -68,7 +71,7 @@ $(QEMU_PROG).stp: $(BUILD_DIR)/trace-events-all
--target-type=$(TARGET_TYPE) \
$< > $@,"GEN","$(TARGET_DIR)$(QEMU_PROG).stp")
-$(QEMU_PROG)-simpletrace.stp: $(BUILD_DIR)/trace-events-all
+$(QEMU_PROG)-simpletrace.stp: $(BUILD_DIR)/trace-events-all $(tracetool-y)
$(call quiet-command,$(TRACETOOL) \
--group=all \
--format=simpletrace-stap \
--
2.13.3
next prev parent reply other threads:[~2017-08-01 13:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 13:16 [Qemu-devel] [PULL 0/9] Tracing patches Stefan Hajnoczi
2017-08-01 13:16 ` Stefan Hajnoczi [this message]
2017-08-01 13:16 ` [Qemu-devel] [PULL 2/9] trace: ensure unique function / variable names per .stp file Stefan Hajnoczi
2017-08-01 13:16 ` [Qemu-devel] [PULL 3/9] trace: add TRACE_<event>_BACKEND_DSTATE() Stefan Hajnoczi
2017-08-01 13:16 ` [Qemu-devel] [PULL 4/9] trace: add trace_event_get_state_backends() Stefan Hajnoczi
2017-08-01 13:16 ` [Qemu-devel] [PULL 5/9] coding_style: add point about 0x in trace-events Stefan Hajnoczi
2017-08-01 13:16 ` [Qemu-devel] [PULL 6/9] trace-events: fix code style: %# -> 0x% Stefan Hajnoczi
2017-08-01 13:16 ` [Qemu-devel] [PULL 7/9] checkpatch: check trace-events code style Stefan Hajnoczi
2017-08-29 21:34 ` Alex Williamson
2017-08-01 13:16 ` [Qemu-devel] [PULL 8/9] trace-events: fix code style: print 0x before hex numbers Stefan Hajnoczi
2017-08-01 13:16 ` [Qemu-devel] [PULL 9/9] monitor: Reduce handle_qmp_command() tracing overhead Stefan Hajnoczi
2017-08-01 13:41 ` [Qemu-devel] [PULL 0/9] Tracing patches no-reply
2017-08-01 14:31 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801131618.27332-2-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).