From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcZAH-0000t1-Ki for qemu-devel@nongnu.org; Tue, 01 Aug 2017 11:32:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcZAE-0007mw-H6 for qemu-devel@nongnu.org; Tue, 01 Aug 2017 11:32:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55737) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dcZAE-0007m5-Bi for qemu-devel@nongnu.org; Tue, 01 Aug 2017 11:32:54 -0400 Date: Tue, 1 Aug 2017 18:32:40 +0300 From: "Michael S. Tsirkin" Message-ID: <20170801183208-mutt-send-email-mst@kernel.org> References: <1501285073-2215-1-git-send-email-zuban32s@gmail.com> <1501285073-2215-3-git-send-email-zuban32s@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Bezzubikov Cc: Marcel Apfelbaum , qemu-devel@nongnu.org, Kevin OConnor , lersek@redhat.com, seabios@seabios.org, Gerd Hoffmann , Igor Mammedov , pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote: > >> +typedef struct PCIEPCIBridge { > >> + /*< private >*/ > >> + PCIBridge parent_obj; > >> + > >> + bool msi_enable; > > > > > > Please rename the msi_enable property to "msi" in order > > to be aligned with the existent PCIBridgeDev and > > consider making it OnOffAuto for the same reason. > > (I am not sure about the last part though, we have > > no meaning for "auto" here) > > > > Agreed about "msi", but OnOffAuto looks weird to me > as we always want MSI to be enabled. Why even have a property then? Can't you enable it unconditionally? -- MST