From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcgAu-0008Gw-UB for qemu-devel@nongnu.org; Tue, 01 Aug 2017 19:02:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcgAr-00073l-TF for qemu-devel@nongnu.org; Tue, 01 Aug 2017 19:02:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37672) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dcgAr-00072r-NV for qemu-devel@nongnu.org; Tue, 01 Aug 2017 19:02:01 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 163DBAE45B for ; Tue, 1 Aug 2017 23:01:59 +0000 (UTC) From: Eduardo Habkost Date: Tue, 1 Aug 2017 20:01:55 -0300 Message-Id: <20170801230155.21083-1-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH] virtio: Mark virtio-device as non-user-creatable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Markus Armbruster , "Michael S. Tsirkin" TYPE_VIRTIO_DEVICE devices are already not usable with -device and device_add, but they are reported as user-creatable on "-device help" and through monitor interfaces. Mark them as not user-creatable to avoid confusing users, and to allow automated testing (e.g. scripts/device-crash-test) to skip them. Before this patch, device-crash-test will try to test virtio-device devices with all machine-types: $ time ./scripts/device-crash-test -D virtio-device -v ./x86_64-softmmu/qemu-system-x86_64 [...] INFO: Total: 1088 test cases INFO: Skipped 408 test cases real 0m49.775s After this patch, the script won't try to test virtio-device devices: $ time ./scripts/device-crash-test -D virtio-device -v ./x86_64-softmmu/qemu-system-x86_64 INFO: Total: 0 test cases real 0m0.092s Signed-off-by: Eduardo Habkost --- hw/virtio/virtio.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 464947f..c4bdb94 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -2653,6 +2653,17 @@ static void virtio_device_class_init(ObjectClass *klass, void *data) dc->unrealize = virtio_device_unrealize; dc->bus_type = TYPE_VIRTIO_BUS; dc->props = virtio_properties; + /* + * Reason: + * - TYPE_VIRTIO_DEVICE devices are not visible to guests + * unless they are created and controlled by transport-specific + * devices (virtio-pci, virtio-mmio, and virtio-ccw). + * - A TYPE_VIRTIO_BUS bus is never available for plugging + * using -device/device_add, as virtio-bus buses are + * created on the fly and immediately populated by the + * transport-specific devices' realize methods. + */ + dc->user_creatable = false; vdc->start_ioeventfd = virtio_device_start_ioeventfd_impl; vdc->stop_ioeventfd = virtio_device_stop_ioeventfd_impl; -- 2.9.4