From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dciG0-0007vT-Pq for qemu-devel@nongnu.org; Tue, 01 Aug 2017 21:15:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dciFx-0001kY-Ju for qemu-devel@nongnu.org; Tue, 01 Aug 2017 21:15:28 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39855 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dciFx-0001kE-Ej for qemu-devel@nongnu.org; Tue, 01 Aug 2017 21:15:25 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v721Duxn027947 for ; Tue, 1 Aug 2017 21:15:24 -0400 Received: from e23smtp07.au.ibm.com (e23smtp07.au.ibm.com [202.81.31.140]) by mx0b-001b2d01.pphosted.com with ESMTP id 2c34691rq5-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 01 Aug 2017 21:15:24 -0400 Received: from localhost by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 Aug 2017 11:15:21 +1000 Received: from d23av06.au.ibm.com (d23av06.au.ibm.com [9.190.235.151]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v721FJ0724903702 for ; Wed, 2 Aug 2017 11:15:19 +1000 Received: from d23av06.au.ibm.com (localhost [127.0.0.1]) by d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v721FJvt029996 for ; Wed, 2 Aug 2017 11:15:19 +1000 Date: Wed, 2 Aug 2017 09:15:18 +0800 From: Dong Jia Shi References: <20170801075727.31335-1-bjsdjshi@linux.vnet.ibm.com> <20170801075727.31335-2-bjsdjshi@linux.vnet.ibm.com> <5c4c144e-7526-71cf-cd7a-c4ca4d2eff60@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c4c144e-7526-71cf-cd7a-c4ca4d2eff60@linux.vnet.ibm.com> Message-Id: <20170802011518.GB24907@bjsdjshi@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 1/2] s390x/css: use macro for event-information pending error recover code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic Cc: Dong Jia Shi , qemu-devel@nongnu.org, cohuck@redhat.com, borntraeger@de.ibm.com, agraf@suse.de, rth@twiddle.net, pmorel@linux.vnet.ibm.com * Halil Pasic [2017-08-01 17:24:10 +0200]: > > > On 08/01/2017 09:57 AM, Dong Jia Shi wrote: > > Let's use a macro for the ERC (error recover code) when generating a > > Channel Subsystem Event-information pending CRW (channel report word). > > > > While we are at it, let's also add all other ERCs. > > > > Signed-off-by: Dong Jia Shi > > --- > > hw/s390x/css.c | 2 +- > > include/hw/s390x/ioinst.h | 11 +++++++++-- > > 2 files changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/hw/s390x/css.c b/hw/s390x/css.c > > index 6a42b95cee..5321ca016b 100644 > > --- a/hw/s390x/css.c > > +++ b/hw/s390x/css.c > > @@ -2103,7 +2103,7 @@ void css_generate_chp_crws(uint8_t cssid, uint8_t chpid) > > void css_generate_css_crws(uint8_t cssid) > > { > > if (!channel_subsys.sei_pending) { > > - css_queue_crw(CRW_RSC_CSS, 0, 0, cssid); > > + css_queue_crw(CRW_RSC_CSS, CRW_ERC_EVENT, 0, cssid); > > } > > channel_subsys.sei_pending = true; > > } > > diff --git a/include/hw/s390x/ioinst.h b/include/hw/s390x/ioinst.h > > index 92d15655e4..f89019f78f 100644 > > --- a/include/hw/s390x/ioinst.h > > +++ b/include/hw/s390x/ioinst.h > > @@ -201,8 +201,15 @@ typedef struct CRW { > > #define CRW_FLAGS_MASK_A 0x0080 > > #define CRW_FLAGS_MASK_ERC 0x003f > > > > -#define CRW_ERC_INIT 0x02 > > -#define CRW_ERC_IPI 0x04 > > +#define CRW_ERC_EVENT 0x00 /* event information pending */ > > +#define CRW_ERC_AVAIL 0x01 /* available */ > > +#define CRW_ERC_INIT 0x02 /* initialized */ > > +#define CRW_ERC_TERROR 0x03 /* temporary error */ > > +#define CRW_ERC_IPI 0x04 /* installed parm initialized */ > > +#define CRW_ERC_TERM 0x05 /* terminal */ > > +#define CRW_ERC_PERRN 0x06 /* perm. error, facility not init */ > > +#define CRW_ERC_PERRI 0x07 /* perm. error, facility init */ > > +#define CRW_ERC_PMOD 0x08 /* installed parameters modified */ > > You have missed installed parameters restored from the PoP (above > you say add all other). Ok. Will add: #define CRW_ERC_IPR 0x0A /* installed parameters restored */ > > Other than that. > > LGTM > > > > > #define CRW_RSC_SUBCH 0x3 > > #define CRW_RSC_CHP 0x4 > > -- Dong Jia Shi