From: Peter Xu <peterx@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] migration: fix small leaks
Date: Wed, 2 Aug 2017 14:09:04 +0800 [thread overview]
Message-ID: <20170802060903.GA4475@pxdev.xzpeter.org> (raw)
In-Reply-To: <20170801160419.14180-1-marcandre.lureau@redhat.com>
On Tue, Aug 01, 2017 at 05:04:18PM +0100, Marc-André Lureau wrote:
> Spotted thanks to valgrind and tests/device-introspect-test:
>
> ==11711== 1 bytes in 1 blocks are definitely lost in loss record 6 of 14,537
> ==11711== at 0x4C2EB6B: malloc (vg_replace_malloc.c:299)
> ==11711== by 0x1E0CDBD8: g_malloc (gmem.c:94)
> ==11711== by 0x1E0E696E: g_strdup (gstrfuncs.c:363)
> ==11711== by 0x695693: migration_instance_init (migration.c:2226)
> ==11711== by 0x717C4B: object_init_with_type (object.c:344)
> ==11711== by 0x717E80: object_initialize_with_type (object.c:375)
> ==11711== by 0x7182EB: object_new_with_type (object.c:483)
> ==11711== by 0x718328: object_new (object.c:493)
> ==11711== by 0x4B8A29: qmp_device_list_properties (qmp.c:542)
> ==11711== by 0x4A9561: qmp_marshal_device_list_properties (qmp-marshal.c:1425)
> ==11711== by 0x819D4A: do_qmp_dispatch (qmp-dispatch.c:104)
> ==11711== by 0x819E82: qmp_dispatch (qmp-dispatch.c:131)
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2017-08-02 6:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 16:04 [Qemu-devel] [PATCH] migration: fix small leaks Marc-André Lureau
2017-08-02 6:09 ` Peter Xu [this message]
2017-08-02 6:58 ` Juan Quintela
2017-08-02 10:26 ` Dr. David Alan Gilbert
2017-12-27 12:25 ` Vladimir Sementsov-Ogievskiy
2017-12-28 2:19 ` Peter Xu
2017-12-28 9:16 ` Vladimir Sementsov-Ogievskiy
2018-01-02 15:19 ` Dr. David Alan Gilbert
2018-01-03 2:33 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802060903.GA4475@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).