From: Stefan Hajnoczi <stefanha@redhat.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>
Cc: qemu-devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Alberto Garcia <berto@igalia.com>,
qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/3] block: skip implicit nodes in snapshots, blockjobs
Date: Wed, 2 Aug 2017 10:52:26 +0100 [thread overview]
Message-ID: <20170802095226.GC5531@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170801134907.31253-3-el13635@mail.ntua.gr>
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
On Tue, Aug 01, 2017 at 04:49:06PM +0300, Manos Pitsidianakis wrote:
> diff --git a/block.c b/block.c
> index 886a457ab0..9ebdba28b0 100644
> --- a/block.c
> +++ b/block.c
> @@ -4947,3 +4947,20 @@ bool bdrv_can_store_new_dirty_bitmap(BlockDriverState *bs, const char *name,
>
> return drv->bdrv_can_store_new_dirty_bitmap(bs, name, granularity, errp);
> }
> +
> +/* Get first non-implicit node down a bs chain. */
> +BlockDriverState *bdrv_get_first_non_implicit(BlockDriverState *bs)
Linguistically non-implicit == explicit and that would be simpler.
Alternatives to implicit/explicit are:
transient/permanent
internal/external
self-created/user-created
worker/user
Let's agree on one and use it consistently. I like the worker nodes vs
user nodes because it reflects their function.
implicit/explicit is fine by me too. I just think non-implicit is
clunky.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-08-02 9:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 13:49 [Qemu-devel] [PATCH 0/3] block: remove legacy I/O throttling Manos Pitsidianakis
2017-08-01 13:49 ` [Qemu-devel] [PATCH 1/3] block: add options parameter to bdrv_new_open_driver() Manos Pitsidianakis
2017-08-02 9:33 ` Stefan Hajnoczi
2017-08-01 13:49 ` [Qemu-devel] [PATCH 2/3] block: skip implicit nodes in snapshots, blockjobs Manos Pitsidianakis
2017-08-02 9:52 ` Stefan Hajnoczi [this message]
2017-08-03 10:22 ` Kevin Wolf
2017-08-01 13:49 ` [Qemu-devel] [PATCH 3/3] block: remove legacy I/O throttling Manos Pitsidianakis
2017-08-02 10:07 ` Stefan Hajnoczi
2017-08-02 10:33 ` Kevin Wolf
2017-08-02 16:46 ` Manos Pitsidianakis
2017-08-02 10:34 ` Manos Pitsidianakis
2017-08-02 14:36 ` Stefan Hajnoczi
2017-08-03 11:10 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802095226.GC5531@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=berto@igalia.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).