qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Cc: Halil Pasic <pasic@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, borntraeger@de.ibm.com, agraf@suse.de,
	rth@twiddle.net, pmorel@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2 1/2] s390x/css: use macro for event-information pending error recover code
Date: Wed, 2 Aug 2017 11:57:26 +0200	[thread overview]
Message-ID: <20170802115726.1e858735@gondolin> (raw)
In-Reply-To: <20170802011518.GB24907@bjsdjshi@linux.vnet.ibm.com>

On Wed, 2 Aug 2017 09:15:18 +0800
Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> wrote:

> * Halil Pasic <pasic@linux.vnet.ibm.com> [2017-08-01 17:24:10 +0200]:
> 
> > 
> > 
> > On 08/01/2017 09:57 AM, Dong Jia Shi wrote:  
> > > Let's use a macro for the ERC (error recover code) when generating a
> > > Channel Subsystem Event-information pending CRW (channel report word).
> > > 
> > > While we are at it, let's also add all other ERCs.
> > > 
> > > Signed-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
> > > ---
> > >  hw/s390x/css.c            |  2 +-
> > >  include/hw/s390x/ioinst.h | 11 +++++++++--
> > >  2 files changed, 10 insertions(+), 3 deletions(-)

(...)

> > > diff --git a/include/hw/s390x/ioinst.h b/include/hw/s390x/ioinst.h
> > > index 92d15655e4..f89019f78f 100644
> > > --- a/include/hw/s390x/ioinst.h
> > > +++ b/include/hw/s390x/ioinst.h
> > > @@ -201,8 +201,15 @@ typedef struct CRW {
> > >  #define CRW_FLAGS_MASK_A 0x0080
> > >  #define CRW_FLAGS_MASK_ERC 0x003f
> > > 
> > > -#define CRW_ERC_INIT 0x02
> > > -#define CRW_ERC_IPI  0x04
> > > +#define CRW_ERC_EVENT    0x00 /* event information pending */
> > > +#define CRW_ERC_AVAIL    0x01 /* available */
> > > +#define CRW_ERC_INIT     0x02 /* initialized */
> > > +#define CRW_ERC_TERROR   0x03 /* temporary error */
> > > +#define CRW_ERC_IPI      0x04 /* installed parm initialized */
> > > +#define CRW_ERC_TERM     0x05 /* terminal */
> > > +#define CRW_ERC_PERRN    0x06 /* perm. error, facility not init */
> > > +#define CRW_ERC_PERRI    0x07 /* perm. error, facility init */
> > > +#define CRW_ERC_PMOD     0x08 /* installed parameters modified */  
> > 
> > You have missed installed parameters restored from the PoP (above
> > you say add all other).  
> Ok. Will add:
> #define CRW_ERC_IPR      0x0A /* installed parameters restored */

Makes sense.

> 
> > 
> > Other than that.
> > 
> > LGTM
> >   
> > > 
> > >  #define CRW_RSC_SUBCH 0x3
> > >  #define CRW_RSC_CHP   0x4
> > >   
> 

  reply	other threads:[~2017-08-02  9:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01  7:57 [Qemu-devel] [PATCH v2 0/2] ERC cleanup and CRW bugfix (was: Channel Path realted CRW generation) Dong Jia Shi
2017-08-01  7:57 ` [Qemu-devel] [PATCH v2 1/2] s390x/css: use macro for event-information pending error recover code Dong Jia Shi
2017-08-01 15:24   ` Halil Pasic
2017-08-02  1:15     ` Dong Jia Shi
2017-08-02  9:57       ` Cornelia Huck [this message]
2017-08-01  7:57 ` [Qemu-devel] [PATCH v2 2/2] s390x/css: generate solicited crw for rchp completion signaling Dong Jia Shi
2017-08-01 15:16   ` Halil Pasic
2017-08-02  1:20     ` Dong Jia Shi
2017-08-02 10:01     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802115726.1e858735@gondolin \
    --to=cohuck@redhat.com \
    --cc=agraf@suse.de \
    --cc=bjsdjshi@linux.vnet.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=pasic@linux.vnet.ibm.com \
    --cc=pmorel@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).