From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com, peterx@redhat.com, marcandre.lureau@redhat.com
Subject: [Qemu-devel] [PULL 2/3] migration: fix comment disorder in RAMState
Date: Wed, 2 Aug 2017 14:58:33 +0100 [thread overview]
Message-ID: <20170802135834.1455-3-dgilbert@redhat.com> (raw)
In-Reply-To: <20170802135834.1455-1-dgilbert@redhat.com>
From: Peter Xu <peterx@redhat.com>
Comments for "migration_dirty_pages" and "bitmap_mutex" are switched.
Fix it.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <1501666880-10159-2-git-send-email-peterx@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/ram.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 1b08296d1b..e18b3e2d4f 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -188,9 +188,9 @@ struct RAMState {
uint64_t iterations_prev;
/* Iterations since start */
uint64_t iterations;
- /* protects modification of the bitmap */
- uint64_t migration_dirty_pages;
/* number of dirty bits in the bitmap */
+ uint64_t migration_dirty_pages;
+ /* protects modification of the bitmap */
QemuMutex bitmap_mutex;
/* The RAMBlock used in the last src_page_requests */
RAMBlock *last_req_rb;
--
2.13.3
next prev parent reply other threads:[~2017-08-02 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 13:58 [Qemu-devel] [PULL 0/3] migration queue Dr. David Alan Gilbert (git)
2017-08-02 13:58 ` [Qemu-devel] [PULL 1/3] migration: fix small leaks Dr. David Alan Gilbert (git)
2017-08-02 13:58 ` Dr. David Alan Gilbert (git) [this message]
2017-08-02 13:58 ` [Qemu-devel] [PULL 3/3] io: fix qio_channel_socket_accept err handling Dr. David Alan Gilbert (git)
2017-08-02 14:50 ` [Qemu-devel] [PULL 0/3] migration queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802135834.1455-3-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).