From: "Michael S. Tsirkin" <mst@redhat.com>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>,
Alexander Bezzubikov <zuban32s@gmail.com>,
qemu-devel@nongnu.org, ehabkost@redhat.com, seabios@seabios.org,
Kevin OConnor <kevin@koconnor.net>,
Gerd Hoffmann <kraxel@redhat.com>,
pbonzini@redhat.com, Igor Mammedov <imammedo@redhat.com>,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v3 5/5] docs: update documentation considering PCIE-PCI bridge
Date: Wed, 2 Aug 2017 19:26:42 +0300 [thread overview]
Message-ID: <20170802192446-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <c4761b15-4525-247c-14da-510b20dbf90a@redhat.com>
On Wed, Aug 02, 2017 at 06:36:29PM +0300, Marcel Apfelbaum wrote:
> > > > > > Can dmi-pci support shpc? why doesn't it? For compatibility?
> > > > >
> > > > > I don't know why, but the fact that it doesn't is the reason libvirt
> > > > > settled on auto-creating a dmi-pci bridge and a pci-pci bridge under
> > > > > that for Q35. The reasoning was (IIRC Laine's words correctly) that the
> > > > > dmi-pci bridge cannot receive hotplugged devices, while the pci-pci
> > > > > bridge cannot be connected to the root complex. So both were needed.
> > > > >
> > > > > Thanks
> > > > > Laszlo
> > > >
> > > > OK. Is it true that dmi-pci + pci-pci under it will allow hotplug
> > > > on Q35 if we just flip the bit in _OSC?
> > >
> > > Marcel, what say you?... :)
>
> Good news, works with:
> -device i82801b11-bridge,id=b1
> -device pci-bridge,id=b2,bus=b1,chassis_nr=1,msi=off
And presumably it works for modern windows?
OK, so it looks like patch 1 is merely a bugfix, I'll merge it for 2.10.
> Notice bridge's msi=off until the following kernel bug will be merged:
> https://www.spinics.net/lists/linux-pci/msg63052.html
Does libvirt support msi=off as a work-around?
>
> Thanks,
> Marcel
--
MST
next prev parent reply other threads:[~2017-08-02 16:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 23:37 [Qemu-devel] [PATCH v3 0/5] Generic PCIE-PCI Bridge Aleksandr Bezzubikov
2017-07-28 23:37 ` [Qemu-devel] [PATCH v3 1/5] hw/i386: allow SHPC for Q35 machine Aleksandr Bezzubikov
2017-07-31 11:03 ` Marcel Apfelbaum
2017-08-03 12:52 ` Michael S. Tsirkin
2017-08-03 12:55 ` Alexander Bezzubikov
2017-08-03 13:05 ` Marcel Apfelbaum
2017-07-28 23:37 ` [Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device Aleksandr Bezzubikov
2017-07-31 11:23 ` Marcel Apfelbaum
2017-07-31 18:40 ` Alexander Bezzubikov
2017-08-01 15:32 ` Michael S. Tsirkin
2017-08-01 15:45 ` Marcel Apfelbaum
2017-08-01 15:51 ` Michael S. Tsirkin
2017-08-01 15:59 ` Marcel Apfelbaum
2017-07-28 23:37 ` [Qemu-devel] [PATCH v3 3/5] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware Aleksandr Bezzubikov
2017-07-31 11:29 ` Marcel Apfelbaum
2017-07-31 18:43 ` Alexander Bezzubikov
2017-07-28 23:37 ` [Qemu-devel] [PATCH v3 4/5] hw/pci: add QEMU-specific PCI capability to Generic PCI Express Root Port Aleksandr Bezzubikov
2017-07-31 11:43 ` Marcel Apfelbaum
2017-07-31 18:45 ` Alexander Bezzubikov
2017-07-28 23:37 ` [Qemu-devel] [PATCH v3 5/5] docs: update documentation considering PCIE-PCI bridge Aleksandr Bezzubikov
2017-07-31 11:56 ` Marcel Apfelbaum
2017-08-01 20:31 ` Laszlo Ersek
2017-08-01 21:33 ` Alexander Bezzubikov
2017-08-01 21:39 ` Michael S. Tsirkin
2017-08-01 22:23 ` Laszlo Ersek
2017-08-02 12:30 ` Marcel Apfelbaum
2017-08-02 13:47 ` Michael S. Tsirkin
2017-08-02 14:16 ` Laszlo Ersek
2017-08-02 14:21 ` Marcel Apfelbaum
2017-08-02 15:36 ` Marcel Apfelbaum
2017-08-02 16:26 ` Michael S. Tsirkin [this message]
2017-08-02 17:58 ` Marcel Apfelbaum
2017-08-03 2:41 ` Laine Stump
2017-08-03 10:29 ` Marcel Apfelbaum
2017-08-03 13:58 ` Laine Stump
2017-08-03 18:59 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802192446-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kevin@koconnor.net \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=marcel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=seabios@seabios.org \
--cc=zuban32s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).