From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dd4nd-0004EF-NV for qemu-devel@nongnu.org; Wed, 02 Aug 2017 21:19:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dd4nZ-0004Ds-KR for qemu-devel@nongnu.org; Wed, 02 Aug 2017 21:19:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37374) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dd4nZ-0004DQ-Do for qemu-devel@nongnu.org; Wed, 02 Aug 2017 21:19:37 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5A5F185363 for ; Thu, 3 Aug 2017 01:19:36 +0000 (UTC) Date: Thu, 3 Aug 2017 04:19:33 +0300 From: "Michael S. Tsirkin" Message-ID: <20170803041922-mutt-send-email-mst@kernel.org> References: <1501515652-33372-1-git-send-email-imammedo@redhat.com> <20170802001139-mutt-send-email-mst@kernel.org> <20170802095122.228fc8a8@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170802095122.228fc8a8@nial.brq.redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.10 0/5] tests: acpi: make sure FADT is compared to reference table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, Marcel Apfelbaum On Wed, Aug 02, 2017 at 09:51:22AM +0200, Igor Mammedov wrote: > On Wed, 2 Aug 2017 00:14:18 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Jul 31, 2017 at 05:40:47PM +0200, Igor Mammedov wrote: > > > While refactoring i386/FADT generation to build_append_int_noprefix() > > > and testing it, It turned out that FADT is only tested for valid > > > checksum but actual test for unintended changes isn't applied to it > > > even though we have reference tables in tree. > > > So here goes a couple of cleanups to reflect what fuctions do + > > > some comments and actual fix. > > > > > > Note to maintainer: > > > FADT reference table is out of sync and should be updated along with > > > series applied. > > > > > > CC: "Michael S. Tsirkin" > > > CC: Marcel Apfelbaum > > > > Absolutely good stuff, but not a bugfix as such (it's not that the > > test is wrong, it's that we skip FADT for now) > > so I don't think this is 2.10 material. > Agreed, it could go in when 2.11 merge window is open. thanks,pls remember to repost or ping then. > > > > > Igor Mammedov (5): > > > tests: acpi: move tested tables array allocation outside of > > > test_acpi_dsdt_table() > > > tests: acpi: init table descriptor in test_dst_table() > > > tests: acpi: rename test_acpi_tables()/test_dst_table() to reflect its > > > usage > > > tests: acpi: add comments to fetch_rsdt_referenced_tables/data->tables > > > usage > > > tests: acpi: fix FADT not being compared to reference table > > > > > > tests/bios-tables-test.c | 30 ++++++++++++++++++------------ > > > 1 file changed, 18 insertions(+), 12 deletions(-) > > > > > > -- > > > 2.7.4