From: Cornelia Huck <cohuck@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, philippe.mathieu.daude@gmail.com,
mst@redhat.com, Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3] build-sys: add --disable-vhost-user
Date: Thu, 3 Aug 2017 11:42:31 +0200 [thread overview]
Message-ID: <20170803114231.5674b185@gondolin> (raw)
In-Reply-To: <20170803090746.30532-1-marcandre.lureau@redhat.com>
On Thu, 3 Aug 2017 11:07:46 +0200
Marc-André Lureau <marcandre.lureau@redhat.com> wrote:
> Learn to compile out vhost-user (net, scsi & upcoming users). Keep it
> enabled by default on non-win32, that is assumed to be POSIX. Fail if
> trying to enable it on win32.
>
> When trying to make a vhost-user netdev, it gives the following error:
>
> -netdev vhost-user,id=foo,chardev=chr-test: Parameter 'type' expects a netdev backend type
>
> And similar error with the HMP/QMP monitors.
>
> While at it, rename CONFIG_VHOST_NET_TEST CONFIG_VHOST_USER_NET_TEST
> since it's a vhost-user specific variable.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> hw/virtio/virtio-pci.c | 4 ++--
> configure | 28 ++++++++++++++++++++++++++--
> default-configs/pci.mak | 2 +-
> default-configs/s390x-softmmu.mak | 2 +-
> tests/Makefile.include | 6 +++---
> 5 files changed, 33 insertions(+), 9 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2017-08-03 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 9:07 [Qemu-devel] [PATCH v3] build-sys: add --disable-vhost-user Marc-André Lureau
2017-08-03 9:42 ` Cornelia Huck [this message]
2017-08-05 7:39 ` Thomas Huth
2017-08-06 21:18 ` Paolo Bonzini
2017-08-08 12:37 ` Marc-André Lureau
2017-08-08 12:46 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803114231.5674b185@gondolin \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=philippe.mathieu.daude@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).