From: Manos Pitsidianakis <el13635@mail.ntua.gr>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Alberto Garcia <berto@igalia.com>,
qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver
Date: Thu, 3 Aug 2017 14:48:56 +0300 [thread overview]
Message-ID: <20170803114856.ardy4zn24yanjhlj@postretch> (raw)
In-Reply-To: <20170803080741.GA4456@dhcp-200-186.str.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 19592 bytes --]
On Thu, Aug 03, 2017 at 10:07:41AM +0200, Kevin Wolf wrote:
>Am 31.07.2017 um 11:54 hat Manos Pitsidianakis geschrieben:
>> +/* Extract ThrottleConfig options. Assumes cfg is initialized and will be
>> + * checked for validity.
>> + */
>> +static int throttle_extract_options(QemuOpts *opts, ThrottleConfig *cfg,
>> + Error **errp)
>> +{
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_BPS_TOTAL)) {
>> + cfg->buckets[THROTTLE_BPS_TOTAL].avg =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX QEMU_OPT_BPS_TOTAL,
>> + 0);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_BPS_READ)) {
>> + cfg->buckets[THROTTLE_BPS_READ].avg =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX QEMU_OPT_BPS_READ,
>> + 0);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_BPS_WRITE)) {
>> + cfg->buckets[THROTTLE_BPS_WRITE].avg =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX QEMU_OPT_BPS_WRITE,
>> + 0);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_TOTAL)) {
>> + cfg->buckets[THROTTLE_OPS_TOTAL].avg =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_TOTAL,
>> + 0);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_READ)) {
>> + cfg->buckets[THROTTLE_OPS_READ].avg =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_READ,
>> + 0);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_WRITE)) {
>> + cfg->buckets[THROTTLE_OPS_WRITE].avg =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_WRITE,
>> + 0);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_BPS_TOTAL_MAX)) {
>> + cfg->buckets[THROTTLE_BPS_TOTAL].max =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_BPS_TOTAL_MAX, 0);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_BPS_READ_MAX)) {
>> + cfg->buckets[THROTTLE_BPS_READ].max =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_BPS_READ_MAX, 0);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_BPS_WRITE_MAX)) {
>> + cfg->buckets[THROTTLE_BPS_WRITE].max =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_BPS_WRITE_MAX, 0);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_TOTAL_MAX)) {
>> + cfg->buckets[THROTTLE_OPS_TOTAL].max =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_IOPS_TOTAL_MAX, 0);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_READ_MAX)) {
>> + cfg->buckets[THROTTLE_OPS_READ].max =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_IOPS_READ_MAX, 0);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_WRITE_MAX)) {
>> + cfg->buckets[THROTTLE_OPS_WRITE].max =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_IOPS_WRITE_MAX, 0);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_BPS_TOTAL_MAX_LENGTH)) {
>> + if (qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_BPS_TOTAL_MAX_LENGTH, 1) > UINT_MAX) {
>> + error_setg(errp, "%s value must be in the range [0, %u]",
>> + THROTTLE_OPT_PREFIX QEMU_OPT_BPS_TOTAL_MAX_LENGTH,
>> + UINT_MAX);
>> + return -1;
>> + }
>> + cfg->buckets[THROTTLE_BPS_TOTAL].burst_length =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_BPS_TOTAL_MAX_LENGTH, 1);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_BPS_READ_MAX_LENGTH)) {
>> + if (qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_BPS_READ_MAX_LENGTH, 1) > UINT_MAX) {
>> + error_setg(errp, "%s must be in the range [0, %u]",
>> + THROTTLE_OPT_PREFIX QEMU_OPT_BPS_READ_MAX_LENGTH,
>> + UINT_MAX);
>> + return -1;
>> + }
>> + cfg->buckets[THROTTLE_BPS_READ].burst_length =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_BPS_READ_MAX_LENGTH, 1);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_BPS_WRITE_MAX_LENGTH)) {
>> + if (qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_BPS_WRITE_MAX_LENGTH, 1) > UINT_MAX) {
>> + error_setg(errp, "%s must be in the range [0, %u]",
>> + THROTTLE_OPT_PREFIX QEMU_OPT_BPS_WRITE_MAX_LENGTH,
>> + UINT_MAX);
>> + return -1;
>> + }
>> + cfg->buckets[THROTTLE_BPS_WRITE].burst_length =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_BPS_WRITE_MAX_LENGTH, 1);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_TOTAL_MAX_LENGTH)) {
>> + if (qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_IOPS_TOTAL_MAX_LENGTH, 1) > UINT_MAX) {
>> + error_setg(errp, "%s must be in the range [0, %u]",
>> + THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_TOTAL_MAX_LENGTH,
>> + UINT_MAX);
>> + return -1;
>> + }
>> + cfg->buckets[THROTTLE_OPS_TOTAL].burst_length =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_IOPS_TOTAL_MAX_LENGTH, 1);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_READ_MAX_LENGTH)) {
>> + if (qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_IOPS_READ_MAX_LENGTH, 1) > UINT_MAX) {
>> + error_setg(errp, "%s must be in the range [0, %u]",
>> + THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_READ_MAX_LENGTH,
>> + UINT_MAX);
>> + return -1;
>> + }
>> + cfg->buckets[THROTTLE_OPS_READ].burst_length =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_IOPS_READ_MAX_LENGTH, 1);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_WRITE_MAX_LENGTH)) {
>> + if (qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_IOPS_WRITE_MAX_LENGTH, 1) > UINT_MAX) {
>> + error_setg(errp, "%s must be in the range [0, %u]",
>> + THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_WRITE_MAX_LENGTH,
>> + UINT_MAX);
>> + return -1;
>> + }
>> + cfg->buckets[THROTTLE_OPS_WRITE].burst_length =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX
>> + QEMU_OPT_IOPS_WRITE_MAX_LENGTH, 1);
>> + }
>> + if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_SIZE)) {
>> + cfg->op_size =
>> + qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX QEMU_OPT_IOPS_SIZE,
>> + 0);
>> + }
>> + return 0;
>> +}
>
>This function is very repetitive, but each block is long enough that
>you have to look closely to review whether the right constants are used
>everywhere.
>
>Maybe this could become a bit more readable with a macro or two?
How about this?
# #define IF_OPT_SET(rvalue,opt_name) \
# if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX opt_name)) { \
# rvalue = qemu_opt_get_number(opts, THROTTLE_OPT_PREFIX opt_name, 0); }
# IF_OPT_SET(cfg->buckets[THROTTLE_BPS_TOTAL].avg, QEMU_OPT_BPS_TOTAL);
# IF_OPT_SET(cfg->buckets[THROTTLE_BPS_READ].avg, QEMU_OPT_BPS_READ);
# IF_OPT_SET(cfg->buckets[THROTTLE_BPS_WRITE].avg, QEMU_OPT_BPS_WRITE);
# IF_OPT_SET(cfg->buckets[THROTTLE_OPS_TOTAL].avg, QEMU_OPT_IOPS_TOTAL);
# IF_OPT_SET(cfg->buckets[THROTTLE_OPS_READ].avg, QEMU_OPT_IOPS_READ);
# IF_OPT_SET(cfg->buckets[THROTTLE_OPS_WRITE].avg, QEMU_OPT_IOPS_WRITE);
# IF_OPT_SET(cfg->buckets[THROTTLE_BPS_TOTAL].max, QEMU_OPT_BPS_TOTAL_MAX);
# IF_OPT_SET(cfg->buckets[THROTTLE_BPS_READ].max , QEMU_OPT_BPS_READ_MAX);
# IF_OPT_SET(cfg->buckets[THROTTLE_BPS_WRITE].max, QEMU_OPT_BPS_WRITE_MAX);
# IF_OPT_SET(cfg->buckets[THROTTLE_OPS_TOTAL].max, QEMU_OPT_IOPS_TOTAL_MAX);
# IF_OPT_SET(cfg->buckets[THROTTLE_OPS_READ].max, QEMU_OPT_IOPS_READ_MAX);
# IF_OPT_SET(cfg->buckets[THROTTLE_OPS_WRITE].max, QEMU_OPT_IOPS_WRITE_MAX);
# IF_OPT_SET(cfg->op_size, QEMU_OPT_IOPS_SIZE);
# #define IF_OPT_UINT_SET(rvalue,opt_name) \
# if (qemu_opt_get(opts, THROTTLE_OPT_PREFIX opt_name)) { \
# if (qemu_opt_get_number(opts, \
# THROTTLE_OPT_PREFIX opt_name, 1) > UINT_MAX) { \
# error_setg(errp, "%s value must be in the range [0, %u]", \
# THROTTLE_OPT_PREFIX opt_name, UINT_MAX); \
# return -1; \
# } \
# rvalue = qemu_opt_get_number(opts, opt_name, 1); \
# }
# IF_OPT_UINT_SET(cfg->buckets[THROTTLE_BPS_TOTAL].burst_length,
# QEMU_OPT_BPS_TOTAL_MAX_LENGTH);
# IF_OPT_UINT_SET(cfg->buckets[THROTTLE_BPS_READ].burst_length,
# QEMU_OPT_BPS_READ_MAX_LENGTH);
# IF_OPT_UINT_SET(cfg->buckets[THROTTLE_BPS_WRITE].burst_length,
# QEMU_OPT_BPS_WRITE_MAX_LENGTH);
# IF_OPT_UINT_SET(cfg->buckets[THROTTLE_OPS_TOTAL].burst_length,
# QEMU_OPT_IOPS_TOTAL_MAX_LENGTH);
# IF_OPT_UINT_SET(cfg->buckets[THROTTLE_OPS_READ].burst_length,
# QEMU_OPT_IOPS_READ_MAX_LENGTH);
# IF_OPT_UINT_SET(cfg->buckets[THROTTLE_OPS_WRITE].burst_length,
# QEMU_OPT_IOPS_WRITE_MAX_LENGTH);
>> +static int throttle_configure_tgm(BlockDriverState *bs,
>> + ThrottleGroupMember *tgm,
>> + QDict *options, Error **errp)
>> +{
>> + int ret;
>> + ThrottleConfig cfg;
>> + const char *group_name = NULL;
>> + Error *local_err = NULL;
>> + QemuOpts *opts = qemu_opts_create(&throttle_opts, NULL, 0, &local_err);
>> + if (local_err) {
>> + error_propagate(errp, local_err);
>> + return -EINVAL;
>> + }
>
>As Stefan said, qemu_opts_create() can't fail if you pass NULL for id,
>so you can just use &error_abort.
>
>> +
>> + qemu_opts_absorb_qdict(opts, options, &local_err);
>> + if (local_err) {
>> + error_propagate(errp, local_err);
>> + goto err;
>> + }
>> +
>> + /* If no name is specified, an anonymous group will be created */
>> + group_name = qemu_opt_get(opts, QEMU_OPT_THROTTLE_GROUP_NAME);
>> +
>> + /* Register membership to group with name group_name */
>> + throttle_group_register_tgm(tgm, group_name, bdrv_get_aio_context(bs));
>
>The documentation of throttle_group_register_tgm() suggests that you
>have to pass a string here, but group_name can be NULL if the option
>wasn't given. Probably just means that the comment for that function
>needs to be updated.
>
>> + /* Copy previous configuration */
>> + throttle_group_get_config(tgm, &cfg);
>> +
>> + /* Change limits if user has specified them */
>> + if (throttle_extract_options(opts, &cfg, errp) ||
>> + !throttle_is_valid(&cfg, errp)) {
>> + throttle_group_unregister_tgm(tgm);
>> + goto err;
>> + }
>> + /* Update group configuration */
>> + throttle_group_config(tgm, &cfg);
>> +
>> + ret = 0;
>> + goto fin;
>> +
>> +err:
>> + ret = -EINVAL;
>> +fin:
>> + qemu_opts_del(opts);
>> + return ret;
>> +}
>> +
>> +static int throttle_open(BlockDriverState *bs, QDict *options,
>> + int flags, Error **errp)
>> +{
>> + ThrottleGroupMember *tgm = bs->opaque;
>> +
>> + bs->file = bdrv_open_child(NULL, options, "file",
>> + bs, &child_file, false, errp);
>
>Indentation is off.
>
>> + if (!bs->file) {
>> + return -EINVAL;
>> + }
>> +
>> + return throttle_configure_tgm(bs, tgm, options, errp);
>> +}
>> +
>> +static void throttle_close(BlockDriverState *bs)
>> +{
>> + ThrottleGroupMember *tgm = bs->opaque;
>> + throttle_group_unregister_tgm(tgm);
>> +}
>> +
>> +
>> +static int64_t throttle_getlength(BlockDriverState *bs)
>> +{
>> + return bdrv_getlength(bs->file->bs);
>> +}
>> +
>> +
>> +static int coroutine_fn throttle_co_preadv(BlockDriverState *bs,
>> + uint64_t offset, uint64_t bytes,
>> + QEMUIOVector *qiov, int flags)
>> +{
>> +
>> + ThrottleGroupMember *tgm = bs->opaque;
>> + throttle_group_co_io_limits_intercept(tgm, bytes, false);
>> +
>> + return bdrv_co_preadv(bs->file, offset, bytes, qiov, flags);
>> +}
>> +
>> +static int coroutine_fn throttle_co_pwritev(BlockDriverState *bs,
>> + uint64_t offset, uint64_t bytes,
>> + QEMUIOVector *qiov, int flags)
>> +{
>> + ThrottleGroupMember *tgm = bs->opaque;
>> + throttle_group_co_io_limits_intercept(tgm, bytes, true);
>> +
>> + return bdrv_co_preadv(bs->file, offset, bytes, qiov, flags);
>> +}
>
>I think we want to set BlockDriver.supported_write_flags so that passing
>down flags is actually of any use.
Can you explain what you mean? Do you mean doing this in
throttle_open():
bs->supported_write_flags = bs->file->bs->supported_write_flags;
bs->supported_zero_flags = bs->file->bs->supported_zero_flags;
>
>> +
>> +static int coroutine_fn throttle_co_pwrite_zeroes(BlockDriverState *bs,
>> + int64_t offset, int bytes, BdrvRequestFlags flags)
>> +{
>> + ThrottleGroupMember *tgm = bs->opaque;
>> + throttle_group_co_io_limits_intercept(tgm, bytes, true);
>> +
>> + return bdrv_co_pwrite_zeroes(bs->file, offset, bytes, flags);
>> +}
>
>The same is true for BlockDriver.supported_zero_flags.
>
>> +static int coroutine_fn throttle_co_pdiscard(BlockDriverState *bs,
>> + int64_t offset, int bytes)
>> +{
>> + ThrottleGroupMember *tgm = bs->opaque;
>> + throttle_group_co_io_limits_intercept(tgm, bytes, true);
>> +
>> + return bdrv_co_pdiscard(bs->file->bs, offset, bytes);
>> +}
>> +
>> +static int throttle_co_flush(BlockDriverState *bs)
>> +{
>> + return bdrv_co_flush(bs->file->bs);
>> +}
>> +
>> +static void throttle_detach_aio_context(BlockDriverState *bs)
>> +{
>> + ThrottleGroupMember *tgm = bs->opaque;
>> + throttle_group_detach_aio_context(tgm);
>> +}
>> +
>> +static void throttle_attach_aio_context(BlockDriverState *bs,
>> + AioContext *new_context)
>
>Indentation is off here...
>
>> +{
>> + ThrottleGroupMember *tgm = bs->opaque;
>> + throttle_group_attach_aio_context(tgm, new_context);
>> +}
>> +
>> +static int throttle_reopen_prepare(BDRVReopenState *reopen_state,
>> + BlockReopenQueue *queue, Error **errp)
>
>...and here.
>
>> +{
>> + ThrottleGroupMember *tgm = NULL;
>> +
>> + assert(reopen_state != NULL);
>> + assert(reopen_state->bs != NULL);
>> +
>> + reopen_state->opaque = g_new0(ThrottleGroupMember, 1);
>> + tgm = reopen_state->opaque;
>> +
>> + return throttle_configure_tgm(reopen_state->bs, tgm, reopen_state->options,
>> + errp);
>> +}
>> +
>> +static void throttle_reopen_commit(BDRVReopenState *state)
>> +{
>> + ThrottleGroupMember *tgm = state->bs->opaque;
>> +
>> + throttle_group_unregister_tgm(tgm);
>> + g_free(state->bs->opaque);
>> + state->bs->opaque = state->opaque;
>> + state->opaque = NULL;
>> +}
>> +
>> +static void throttle_reopen_abort(BDRVReopenState *state)
>> +{
>> + ThrottleGroupMember *tgm = state->opaque;
>> +
>> + throttle_group_unregister_tgm(tgm);
>> + g_free(state->opaque);
>> + state->opaque = NULL;
>> +}
>> +
>> +static bool throttle_recurse_is_first_non_filter(BlockDriverState *bs,
>> + BlockDriverState *candidate)
>> +{
>> + return bdrv_recurse_is_first_non_filter(bs->file->bs, candidate);
>> +}
>> +
>> +static BlockDriver bdrv_throttle = {
>> + .format_name = "throttle",
>> + .protocol_name = "throttle",
>> + .instance_size = sizeof(ThrottleGroupMember),
>> +
>> + .bdrv_file_open = throttle_open,
>> + .bdrv_close = throttle_close,
>> + .bdrv_co_flush = throttle_co_flush,
>> +
>> + .bdrv_child_perm = bdrv_filter_default_perms,
>> +
>> + .bdrv_getlength = throttle_getlength,
>> +
>> + .bdrv_co_preadv = throttle_co_preadv,
>> + .bdrv_co_pwritev = throttle_co_pwritev,
>> +
>> + .bdrv_co_pwrite_zeroes = throttle_co_pwrite_zeroes,
>> + .bdrv_co_pdiscard = throttle_co_pdiscard,
>> +
>> + .bdrv_recurse_is_first_non_filter = throttle_recurse_is_first_non_filter,
>> +
>> + .bdrv_attach_aio_context = throttle_attach_aio_context,
>> + .bdrv_detach_aio_context = throttle_detach_aio_context,
>> +
>> + .bdrv_reopen_prepare = throttle_reopen_prepare,
>> + .bdrv_reopen_commit = throttle_reopen_commit,
>> + .bdrv_reopen_abort = throttle_reopen_abort,
>> +
>> + .is_filter = true,
>> +};
>
>What about .bdrv_co_get_block_status?
We should use the default implementation here that you merged into your
2.11 tree, thanks for noticing and for all the comments.
>
>> +static void bdrv_throttle_init(void)
>> +{
>> + bdrv_register(&bdrv_throttle);
>> +}
>> +
>> +block_init(bdrv_throttle_init);
>> diff --git a/include/qemu/throttle-options.h b/include/qemu/throttle-options.h
>> index 182b7896e1..3528a8f4a2 100644
>> --- a/include/qemu/throttle-options.h
>> +++ b/include/qemu/throttle-options.h
>> @@ -29,6 +29,7 @@
>> #define QEMU_OPT_BPS_WRITE_MAX "bps-write-max"
>> #define QEMU_OPT_BPS_WRITE_MAX_LENGTH "bps-write-max-length"
>> #define QEMU_OPT_IOPS_SIZE "iops-size"
>> +#define QEMU_OPT_THROTTLE_GROUP_NAME "throttle-group"
>>
>> #define THROTTLE_OPT_PREFIX "throttling."
>> #define THROTTLE_OPTS \
>
>Kevin
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-03 11:49 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 9:54 [Qemu-devel] [PATCH v3 0/7] add throttle block driver filter Manos Pitsidianakis
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 1/7] block: move ThrottleGroup membership to ThrottleGroupMember Manos Pitsidianakis
2017-08-04 11:59 ` Alberto Garcia
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 2/7] block: add aio_context field in ThrottleGroupMember Manos Pitsidianakis
2017-08-04 12:14 ` Alberto Garcia
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 3/7] block: tidy ThrottleGroupMember initializations Manos Pitsidianakis
2017-08-04 12:35 ` Alberto Garcia
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 4/7] block: convert ThrottleGroup to object with QOM Manos Pitsidianakis
2017-08-01 15:47 ` Stefan Hajnoczi
2017-08-01 16:49 ` Manos Pitsidianakis
2017-08-02 10:39 ` Stefan Hajnoczi
2017-08-02 10:57 ` Manos Pitsidianakis
2017-08-02 14:43 ` Stefan Hajnoczi
2017-08-03 8:08 ` Kevin Wolf
2017-08-03 10:53 ` Stefan Hajnoczi
2017-08-03 11:17 ` Kevin Wolf
2017-08-03 12:29 ` Manos Pitsidianakis
2017-08-08 13:01 ` Alberto Garcia
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver Manos Pitsidianakis
2017-08-01 16:14 ` Stefan Hajnoczi
2017-08-03 8:07 ` Kevin Wolf
2017-08-03 11:48 ` Manos Pitsidianakis [this message]
2017-08-03 12:05 ` Kevin Wolf
2017-08-03 11:58 ` Eric Blake
2017-08-03 13:56 ` Manos Pitsidianakis
2017-08-08 13:13 ` Alberto Garcia
2017-08-08 13:45 ` Manos Pitsidianakis
2017-08-08 14:53 ` Alberto Garcia
2017-08-08 14:56 ` Manos Pitsidianakis
2017-08-08 15:04 ` Alberto Garcia
2017-08-09 9:36 ` Manos Pitsidianakis
2017-08-09 12:36 ` Alberto Garcia
2017-08-09 13:42 ` Manos Pitsidianakis
2017-08-09 14:45 ` Alberto Garcia
2017-08-09 15:39 ` Kevin Wolf
2017-08-14 12:15 ` Manos Pitsidianakis
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 6/7] block: add BlockDevOptionsThrottle to QAPI Manos Pitsidianakis
2017-08-01 16:16 ` Stefan Hajnoczi
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 7/7] block: add throttle block filter driver interface tests Manos Pitsidianakis
2017-08-03 8:07 ` Kevin Wolf
2017-08-03 13:24 ` Manos Pitsidianakis
2017-08-03 13:32 ` Kevin Wolf
2017-08-03 13:52 ` Manos Pitsidianakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803114856.ardy4zn24yanjhlj@postretch \
--to=el13635@mail.ntua.gr \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).