* [Qemu-devel] [PATCH] qemu-web: use https:// to access some external assets
@ 2017-08-03 13:07 Jeff Cody
2017-08-03 13:08 ` Paolo Bonzini
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jeff Cody @ 2017-08-03 13:07 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth, pbonzini
Now that we are using SSL, most (all?) web browsers will by default
block loading mixed content. There are two assets that need to be
changed (Google fonts, and jquery).
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
---
_includes/assets.html | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/_includes/assets.html b/_includes/assets.html
index 3a526a4..826a50f 100644
--- a/_includes/assets.html
+++ b/_includes/assets.html
@@ -2,7 +2,7 @@
<meta name="description" content="" />
<meta name="keywords" content="" />
<meta name="viewport" content="width=device-width">
- <link href='http://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
+ <link href='https://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
<link rel="apple-touch-icon" sizes="180x180" href="/assets/favicons/apple-touch-icon.png">
<link rel="icon" type="image/png" sizes="32x32" href="/assets/favicons/favicon-32x32.png">
@@ -19,7 +19,7 @@
<link rel="stylesheet" href="/assets/css/style-mobile.css" media="(max-width:699px)"/>
<link rel="stylesheet" href="/assets/css/style-desktop.css" media="(min-width:700px)" />
<link rel="alternate" title="QEMU Blog (Atom feed)" href="/feed.xml" type="application/atom+xml" />
- <script src="http://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
+ <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
{% if page.colorbox %}
<script src="/assets/js/jquery.colorbox.js"></script>
<link rel="stylesheet" href="/assets/css/colorbox.css" />
--
2.9.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-web: use https:// to access some external assets
2017-08-03 13:07 [Qemu-devel] [PATCH] qemu-web: use https:// to access some external assets Jeff Cody
@ 2017-08-03 13:08 ` Paolo Bonzini
2017-08-03 13:17 ` Thomas Huth
2017-08-03 13:46 ` Jeff Cody
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2017-08-03 13:08 UTC (permalink / raw)
To: Jeff Cody, qemu-devel; +Cc: thuth
On 03/08/2017 15:07, Jeff Cody wrote:
> Now that we are using SSL, most (all?) web browsers will by default
> block loading mixed content. There are two assets that need to be
> changed (Google fonts, and jquery).
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
> _includes/assets.html | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/_includes/assets.html b/_includes/assets.html
> index 3a526a4..826a50f 100644
> --- a/_includes/assets.html
> +++ b/_includes/assets.html
> @@ -2,7 +2,7 @@
> <meta name="description" content="" />
> <meta name="keywords" content="" />
> <meta name="viewport" content="width=device-width">
> - <link href='http://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
> + <link href='https://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
>
> <link rel="apple-touch-icon" sizes="180x180" href="/assets/favicons/apple-touch-icon.png">
> <link rel="icon" type="image/png" sizes="32x32" href="/assets/favicons/favicon-32x32.png">
> @@ -19,7 +19,7 @@
> <link rel="stylesheet" href="/assets/css/style-mobile.css" media="(max-width:699px)"/>
> <link rel="stylesheet" href="/assets/css/style-desktop.css" media="(min-width:700px)" />
> <link rel="alternate" title="QEMU Blog (Atom feed)" href="/feed.xml" type="application/atom+xml" />
> - <script src="http://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
> + <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
> {% if page.colorbox %}
> <script src="/assets/js/jquery.colorbox.js"></script>
> <link rel="stylesheet" href="/assets/css/colorbox.css" />
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Thanks,
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-web: use https:// to access some external assets
2017-08-03 13:07 [Qemu-devel] [PATCH] qemu-web: use https:// to access some external assets Jeff Cody
2017-08-03 13:08 ` Paolo Bonzini
@ 2017-08-03 13:17 ` Thomas Huth
2017-08-03 13:46 ` Jeff Cody
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2017-08-03 13:17 UTC (permalink / raw)
To: Jeff Cody, qemu-devel; +Cc: pbonzini
On 03.08.2017 15:07, Jeff Cody wrote:
> Now that we are using SSL, most (all?) web browsers will by default
> block loading mixed content. There are two assets that need to be
> changed (Google fonts, and jquery).
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
> _includes/assets.html | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/_includes/assets.html b/_includes/assets.html
> index 3a526a4..826a50f 100644
> --- a/_includes/assets.html
> +++ b/_includes/assets.html
> @@ -2,7 +2,7 @@
> <meta name="description" content="" />
> <meta name="keywords" content="" />
> <meta name="viewport" content="width=device-width">
> - <link href='http://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
> + <link href='https://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
>
> <link rel="apple-touch-icon" sizes="180x180" href="/assets/favicons/apple-touch-icon.png">
> <link rel="icon" type="image/png" sizes="32x32" href="/assets/favicons/favicon-32x32.png">
> @@ -19,7 +19,7 @@
> <link rel="stylesheet" href="/assets/css/style-mobile.css" media="(max-width:699px)"/>
> <link rel="stylesheet" href="/assets/css/style-desktop.css" media="(min-width:700px)" />
> <link rel="alternate" title="QEMU Blog (Atom feed)" href="/feed.xml" type="application/atom+xml" />
> - <script src="http://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
> + <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
> {% if page.colorbox %}
> <script src="/assets/js/jquery.colorbox.js"></script>
> <link rel="stylesheet" href="/assets/css/colorbox.css" />
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-web: use https:// to access some external assets
2017-08-03 13:07 [Qemu-devel] [PATCH] qemu-web: use https:// to access some external assets Jeff Cody
2017-08-03 13:08 ` Paolo Bonzini
2017-08-03 13:17 ` Thomas Huth
@ 2017-08-03 13:46 ` Jeff Cody
2 siblings, 0 replies; 4+ messages in thread
From: Jeff Cody @ 2017-08-03 13:46 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth, pbonzini
On Thu, Aug 03, 2017 at 09:07:43AM -0400, Jeff Cody wrote:
> Now that we are using SSL, most (all?) web browsers will by default
> block loading mixed content. There are two assets that need to be
> changed (Google fonts, and jquery).
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
> _includes/assets.html | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/_includes/assets.html b/_includes/assets.html
> index 3a526a4..826a50f 100644
> --- a/_includes/assets.html
> +++ b/_includes/assets.html
> @@ -2,7 +2,7 @@
> <meta name="description" content="" />
> <meta name="keywords" content="" />
> <meta name="viewport" content="width=device-width">
> - <link href='http://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
> + <link href='https://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
>
> <link rel="apple-touch-icon" sizes="180x180" href="/assets/favicons/apple-touch-icon.png">
> <link rel="icon" type="image/png" sizes="32x32" href="/assets/favicons/favicon-32x32.png">
> @@ -19,7 +19,7 @@
> <link rel="stylesheet" href="/assets/css/style-mobile.css" media="(max-width:699px)"/>
> <link rel="stylesheet" href="/assets/css/style-desktop.css" media="(min-width:700px)" />
> <link rel="alternate" title="QEMU Blog (Atom feed)" href="/feed.xml" type="application/atom+xml" />
> - <script src="http://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
> + <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
> {% if page.colorbox %}
> <script src="/assets/js/jquery.colorbox.js"></script>
> <link rel="stylesheet" href="/assets/css/colorbox.css" />
> --
> 2.9.4
>
Thanks for the reviews. Pushed to git.qemu.org/srv/git/qemu-web.git, and
now live.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-03 13:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-03 13:07 [Qemu-devel] [PATCH] qemu-web: use https:// to access some external assets Jeff Cody
2017-08-03 13:08 ` Paolo Bonzini
2017-08-03 13:17 ` Thomas Huth
2017-08-03 13:46 ` Jeff Cody
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).