From: Eduardo Habkost <ehabkost@redhat.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio: Mark virtio-device as non-user-creatable
Date: Thu, 3 Aug 2017 11:45:08 -0300 [thread overview]
Message-ID: <20170803144508.GI3108@localhost.localdomain> (raw)
In-Reply-To: <61e65941-a035-a1fd-4a09-3dc54aac7354@linux.vnet.ibm.com>
On Wed, Aug 02, 2017 at 02:33:00PM +0200, Halil Pasic wrote:
>
>
> On 08/02/2017 01:01 AM, Eduardo Habkost wrote:
> > TYPE_VIRTIO_DEVICE devices are already not usable with -device
> > and device_add, but they are reported as user-creatable on
> > "-device help" and through monitor interfaces.
>
> I've tried -device virtio-rng on s390x and from what I see, it
> seems we 'auto-magically' create the 'controlling' virtio-rng-ccw
> device. So I have to ask what do you mean by 'already not usable'?
virtio-rng is just an alias for virtio-rng-<transport>, and it's
not a TYPE_VIRTIO_DEVICE device.
virtio-rng-device is the TYPE_VIRTIO_DEVICE subclass, and you
shouldn't be able to use "-device virtio-rng-device". Except
that it works with "qemu-system-arm -machine virt", as I noted on
another message, and this patch breaks it.
--
Eduardo
next prev parent reply other threads:[~2017-08-03 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 23:01 [Qemu-devel] [PATCH] virtio: Mark virtio-device as non-user-creatable Eduardo Habkost
2017-08-02 12:33 ` Halil Pasic
2017-08-03 14:45 ` Eduardo Habkost [this message]
2017-08-03 22:11 ` Halil Pasic
2017-08-02 13:10 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803144508.GI3108@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).