From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddfCX-0001UT-LA for qemu-devel@nongnu.org; Fri, 04 Aug 2017 12:11:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddfCT-0008Vc-Lh for qemu-devel@nongnu.org; Fri, 04 Aug 2017 12:11:49 -0400 Date: Fri, 4 Aug 2017 17:11:35 +0100 From: "Daniel P. Berrange" Message-ID: <20170804161135.GJ14504@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170804151440.320927-1-vsementsov@virtuozzo.com> <20170804151440.320927-6-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170804151440.320927-6-vsementsov@virtuozzo.com> Subject: Re: [Qemu-devel] [PATCH 05/17] block/nbd-client: get rid of ssize_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, kwolf@redhat.com, mreitz@redhat.com, den@openvz.org, pbonzini@redhat.com On Fri, Aug 04, 2017 at 06:14:28PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Use int variable for nbd_co_send_request return value (as > nbd_co_send_request returns int). Hmm, nbd_co_send_request() propagates return value of nbd_send_request, which returns ssize_t. IOW, I think we need to fix nbd_co_send_request to also return ssize_t, rather than changing callers to use int. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|