From: "Daniel P. Berrange" <berrange@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, kwolf@redhat.com,
mreitz@redhat.com, den@openvz.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 05/17] block/nbd-client: get rid of ssize_t
Date: Mon, 7 Aug 2017 09:24:03 +0100 [thread overview]
Message-ID: <20170807082403.GC18259@redhat.com> (raw)
In-Reply-To: <b102b503-ff2f-db95-330f-9780ab4aaeb2@virtuozzo.com>
On Mon, Aug 07, 2017 at 09:57:30AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 04.08.2017 19:11, Daniel P. Berrange wrote:
> > On Fri, Aug 04, 2017 at 06:14:28PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > > Use int variable for nbd_co_send_request return value (as
> > > nbd_co_send_request returns int).
> > Hmm, nbd_co_send_request() propagates return value of nbd_send_request,
> > which returns ssize_t.
>
> See patch 04, nbd_send_request fixed in it to return int. It propagates
> return
> value of nbd_write which is int.
That's wrong too - nbd_write() should have been fixed to have ssize_t
as its return type, since its returning the value of a ssize_t variable.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-08-07 8:24 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 15:14 [Qemu-devel] [PATCH 00/17] nbd client refactoring and fixing Vladimir Sementsov-Ogievskiy
2017-08-04 15:14 ` [Qemu-devel] [PATCH 01/17] nbd/client: fix nbd_opt_go Vladimir Sementsov-Ogievskiy
2017-08-07 11:31 ` Eric Blake
2017-08-04 15:14 ` [Qemu-devel] [PATCH 02/17] nbd/client: refactor nbd_read_eof Vladimir Sementsov-Ogievskiy
2017-08-07 11:42 ` Eric Blake
2017-08-07 12:05 ` Vladimir Sementsov-Ogievskiy
2017-08-25 19:22 ` Eric Blake
2017-08-04 15:14 ` [Qemu-devel] [PATCH 03/17] nbd/client: refactor nbd_receive_reply Vladimir Sementsov-Ogievskiy
2017-08-25 21:16 ` Eric Blake
2017-08-04 15:14 ` [Qemu-devel] [PATCH 04/17] nbd/client: fix nbd_send_request to return int Vladimir Sementsov-Ogievskiy
2017-08-07 8:23 ` Daniel P. Berrange
2017-08-07 8:57 ` Vladimir Sementsov-Ogievskiy
2017-08-07 11:49 ` Eric Blake
2017-08-07 12:03 ` Daniel P. Berrange
2017-08-25 21:20 ` Eric Blake
2017-08-04 15:14 ` [Qemu-devel] [PATCH 05/17] block/nbd-client: get rid of ssize_t Vladimir Sementsov-Ogievskiy
2017-08-04 16:11 ` Daniel P. Berrange
2017-08-07 6:57 ` Vladimir Sementsov-Ogievskiy
2017-08-07 8:24 ` Daniel P. Berrange [this message]
2017-08-25 21:25 ` Eric Blake
2017-08-04 15:14 ` [Qemu-devel] [PATCH 06/17] block/nbd-client: fix nbd_read_reply_entry Vladimir Sementsov-Ogievskiy
2017-08-07 11:52 ` Eric Blake
2017-08-07 12:56 ` Vladimir Sementsov-Ogievskiy
2017-08-07 15:13 ` Eric Blake
2017-08-07 15:33 ` [Qemu-devel] [Qemu-block] " Eric Blake
2017-08-07 16:09 ` Vladimir Sementsov-Ogievskiy
2017-08-07 16:18 ` Eric Blake
2017-08-04 15:14 ` [Qemu-devel] [PATCH 07/17] block/nbd-client: refactor request send/receive Vladimir Sementsov-Ogievskiy
2017-08-25 18:49 ` Eric Blake
2017-08-25 19:08 ` Eric Blake
2017-08-04 15:14 ` [Qemu-devel] [PATCH 08/17] block/nbd-client: rename nbd_recv_coroutines_enter_all Vladimir Sementsov-Ogievskiy
2017-08-25 18:43 ` Eric Blake
2017-08-25 21:48 ` Eric Blake
2017-08-04 15:14 ` [Qemu-devel] [PATCH 09/17] block/nbd-client: move nbd_co_receive_reply content into nbd_co_request Vladimir Sementsov-Ogievskiy
2017-08-25 18:52 ` Eric Blake
2017-08-04 15:14 ` [Qemu-devel] [PATCH 10/17] block/nbd-client: move nbd_coroutine_end " Vladimir Sementsov-Ogievskiy
2017-08-25 21:57 ` Eric Blake
2017-08-04 15:14 ` [Qemu-devel] [PATCH 11/17] block/nbd-client: fix nbd_co_request: set s->reply.handle to 0 on error Vladimir Sementsov-Ogievskiy
2017-08-07 11:55 ` Eric Blake
2017-08-07 13:17 ` Vladimir Sementsov-Ogievskiy
2017-08-04 15:14 ` [Qemu-devel] [PATCH 12/17] block/nbd-client: refactor nbd_co_request Vladimir Sementsov-Ogievskiy
2017-08-04 15:14 ` [Qemu-devel] [PATCH 13/17] block/nbd-client: refactor NBDClientSession.recv_coroutine Vladimir Sementsov-Ogievskiy
2017-08-04 15:14 ` [Qemu-devel] [PATCH 14/17] block/nbd-client: exit reply-reading coroutine on incorrect handle Vladimir Sementsov-Ogievskiy
2017-08-04 15:14 ` [Qemu-devel] [PATCH 15/17] block/nbd-client: refactor reading reply Vladimir Sementsov-Ogievskiy
2017-08-04 15:14 ` [Qemu-devel] [PATCH 16/17] block/nbd-client: drop reply field from NBDClientSession Vladimir Sementsov-Ogievskiy
2017-08-04 15:14 ` [Qemu-devel] [PATCH 17/17] block/nbd-client: always return EIO on and after the first io channel error Vladimir Sementsov-Ogievskiy
2017-08-16 21:21 ` [Qemu-devel] [PATCH 00/17] nbd client refactoring and fixing Eric Blake
2017-08-17 7:37 ` Vladimir Sementsov-Ogievskiy
2017-08-25 22:10 ` Eric Blake
2017-08-29 22:12 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807082403.GC18259@redhat.com \
--to=berrange@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).