From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, borntraeger@de.ibm.com, agraf@suse.de,
thuth@redhat.com, pmorel@linux.vnet.ibm.com,
zyimin@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v4 5/9] s390x/ccw: create s390 phb conditionally
Date: Mon, 7 Aug 2017 12:00:27 +0200 [thread overview]
Message-ID: <20170807120027.75d6b971@gondolin> (raw)
In-Reply-To: <789fa061-be02-9fdb-b01b-bdec4c18d1c4@redhat.com>
On Fri, 4 Aug 2017 15:20:26 +0200
David Hildenbrand <david@redhat.com> wrote:
> On 04.08.2017 13:29, Cornelia Huck wrote:
> > Don't create the s390 pci host bridge if we do not provide the zpci
> > facility.
> >
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
> > Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>
> This works, because s390_init_cpus(machine) (which sets up features) is
> called before adding the bus. Mind to add a comment so nobody tries to
> reshuffle these functions?
This is already needed by the flic setup (which also relies on the
features being set up). We really want the cpu setup as early as
possible.
Do you have a good comment handy? :)
next prev parent reply other threads:[~2017-08-07 10:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 11:29 [Qemu-devel] [PATCH v4 0/9] s390x: zPCI detangling Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 1/9] kvm: remove hard dependency on pci Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 2/9] s390x/pci: add stubs Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 3/9] s390x: chsc nt2 events are pci-only Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 4/9] s390x/pci: do not advertise pci on non-pci builds Cornelia Huck
2017-08-04 13:21 ` David Hildenbrand
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 5/9] s390x/ccw: create s390 phb conditionally Cornelia Huck
2017-08-04 13:20 ` David Hildenbrand
2017-08-07 10:00 ` Cornelia Huck [this message]
2017-08-07 10:21 ` David Hildenbrand
2017-08-07 11:11 ` Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 6/9] s390x/sclp: properly guard pci-specific functions Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 7/9] s390x/pci: fence off instructions for non-pci Cornelia Huck
2017-08-04 13:17 ` David Hildenbrand
2017-08-07 9:52 ` Cornelia Huck
2017-08-07 14:17 ` David Hildenbrand
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 8/9] s390x/kvm: msi route fixup " Cornelia Huck
2017-08-04 13:18 ` David Hildenbrand
2017-08-07 9:54 ` Cornelia Huck
2017-08-04 11:29 ` [Qemu-devel] [PATCH v4 9/9] s390x: refine pci dependencies Cornelia Huck
2017-08-04 13:25 ` David Hildenbrand
2017-08-04 14:59 ` [Qemu-devel] [PATCH v4 0/9] s390x: zPCI detangling Cornelia Huck
2017-08-08 9:15 ` Cornelia Huck
2017-08-08 9:29 ` Thomas Huth
2017-08-08 9:46 ` Cornelia Huck
2017-08-08 10:42 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807120027.75d6b971@gondolin \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=zyimin@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).