From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1deeq6-0007zb-8O for qemu-devel@nongnu.org; Mon, 07 Aug 2017 06:00:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1deeq1-0007Be-Fd for qemu-devel@nongnu.org; Mon, 07 Aug 2017 06:00:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39182) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1deeq1-00079p-9H for qemu-devel@nongnu.org; Mon, 07 Aug 2017 06:00:41 -0400 Date: Mon, 7 Aug 2017 12:00:27 +0200 From: Cornelia Huck Message-ID: <20170807120027.75d6b971@gondolin> In-Reply-To: <789fa061-be02-9fdb-b01b-bdec4c18d1c4@redhat.com> References: <20170804112946.5247-1-cohuck@redhat.com> <20170804112946.5247-6-cohuck@redhat.com> <789fa061-be02-9fdb-b01b-bdec4c18d1c4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 5/9] s390x/ccw: create s390 phb conditionally List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-devel@nongnu.org, borntraeger@de.ibm.com, agraf@suse.de, thuth@redhat.com, pmorel@linux.vnet.ibm.com, zyimin@linux.vnet.ibm.com On Fri, 4 Aug 2017 15:20:26 +0200 David Hildenbrand wrote: > On 04.08.2017 13:29, Cornelia Huck wrote: > > Don't create the s390 pci host bridge if we do not provide the zpci > > facility. > > > > Reviewed-by: Thomas Huth > > Acked-by: Christian Borntraeger > > Signed-off-by: Cornelia Huck > > This works, because s390_init_cpus(machine) (which sets up features) is > called before adding the bus. Mind to add a comment so nobody tries to > reshuffle these functions? This is already needed by the flic setup (which also relies on the features being set up). We really want the cpu setup as early as possible. Do you have a good comment handy? :)