From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dekFK-0003wS-De for qemu-devel@nongnu.org; Mon, 07 Aug 2017 11:47:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dekFF-00032Y-Jr for qemu-devel@nongnu.org; Mon, 07 Aug 2017 11:47:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35392) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dekFF-000324-El for qemu-devel@nongnu.org; Mon, 07 Aug 2017 11:47:05 -0400 Date: Mon, 7 Aug 2017 17:46:59 +0200 From: Cornelia Huck Message-ID: <20170807174659.7faf9ef2@gondolin> In-Reply-To: <870ba6c0-e285-d75a-098e-0a2d1e02e02b@de.ibm.com> References: <20170718142455.32676-1-cohuck@redhat.com> <20170719150313.6acdb087@gondolin> <870ba6c0-e285-d75a-098e-0a2d1e02e02b@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v2 0/9] s390x: zPCI detangling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Thomas Huth , qemu-devel@nongnu.org, agraf@suse.de, pmorel@linux.vnet.ibm.com, zyimin@linux.vnet.ibm.com On Mon, 24 Jul 2017 12:44:43 +0200 Christian Borntraeger wrote: > On 07/19/2017 03:31 PM, Thomas Huth wrote: > > On 19.07.2017 15:03, Cornelia Huck wrote: > >> On Tue, 18 Jul 2017 16:24:46 +0200 > >> Cornelia Huck wrote: > >> > >>> Next try of the zPCI detangling, taking cpu models into account. > >>> > >>> The goal of this is twofold: > >>> - Being able to disable PCI support in a build completely, as for v1. > >>> - Properly fencing off PCI if the relevant facility bit is not provided. > >>> > >>> The second one leads to an interesting usability problem: -device help > >>> still shows the various pci devices, but you cannot add them if the > >>> cpu model does not include zpci, due to the phb not being instantiated. > >>> The user is presented with > >>> > >>> qemu-system-s390x: -device virtio-rng-pci: No 'PCI' bus found for device 'virtio-rng-pci' > >>> > >>> ...which is not very helpful, as it does not point to the root cause (no > >>> zpci in the cpu model, and therefore no pci at all). Not sure how one can > >>> communicate this root cause, ideas welcome. > >> > >> An idea on how to improve this would still be welcome :) > > > > IMHO it's ok to keep that error message ... but we should add a section > > to http://wiki.qemu.org/Documentation/Platforms/S390X about PCI devices, > > including a sample error message as above and a note what has to be done > > to get a machine with PCI support, so that people can find that page via > > Google in case they run into this problem. > > I agree, the message is actually not that bad for an error message. With > an wiki entry we should be fine. > Updated https://wiki.qemu.org/index.php/Documentation/Platforms/S390X with some info... review (or editing :) welcome.