From: Fam Zheng <famz@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH for 2.10 v3 1/6] docker: ensure NOUSER for travis images
Date: Tue, 8 Aug 2017 09:38:46 +0800 [thread overview]
Message-ID: <20170808013846.GO14780@lemon> (raw)
In-Reply-To: <20170807153934.29477-2-alex.bennee@linaro.org>
On Mon, 08/07 16:39, Alex Bennée wrote:
> While adding the current user is a useful default behaviour for
> creating new images it is not appropriate for Travis which already has
> a default user.
Target docker-travis@travis will not have NOUSER=1 automatically, right? Is that
a problem?
Fam
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/docker/Makefile.include | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index aaab1a4208..d7dafdbd27 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -71,6 +71,7 @@ docker-image-debian-ppc64el-cross: docker-image-debian9
> docker-image-debian-s390x-cross: docker-image-debian9
> docker-image-debian-win32-cross: docker-image-debian8-mxe
> docker-image-debian-win64-cross: docker-image-debian8-mxe
> +docker-image-travis: NOUSER=1
>
> # Expand all the pre-requistes for each docker image and test combination
> $(foreach i,$(DOCKER_IMAGES), \
> --
> 2.13.0
>
>
next prev parent reply other threads:[~2017-08-08 1:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 15:39 [Qemu-devel] [PATCH for 2.10 v3 0/6] Various docker fixes Alex Bennée
2017-08-07 15:39 ` [Qemu-devel] [PATCH for 2.10 v3 1/6] docker: ensure NOUSER for travis images Alex Bennée
2017-08-08 1:38 ` Fam Zheng [this message]
2017-08-08 8:55 ` Alex Bennée
2017-08-07 15:39 ` [Qemu-devel] [PATCH for 2.10 v3 2/6] docker: fix dirty/stash detection on some systems Alex Bennée
2017-08-07 15:39 ` [Qemu-devel] [PATCH for 2.10 v3 3/6] docker: ignore submodules when checking diff Alex Bennée
2017-08-07 15:39 ` [Qemu-devel] [PATCH for 2.10 v3 4/6] docker: docker.py make --no-cache skip checksum test Alex Bennée
2017-08-08 1:43 ` Fam Zheng
2017-08-08 8:51 ` Alex Bennée
2017-08-08 12:39 ` Fam Zheng
2017-08-07 15:39 ` [Qemu-devel] [PATCH for 2.10 v3 5/6] docker: don't install device-tree-compiler build-deps in travis.docker Alex Bennée
2017-08-09 13:53 ` Philippe Mathieu-Daudé
2017-08-07 15:39 ` [Qemu-devel] [PATCH for 2.10 v3 6/6] docker: reduce noise when building travis.docker Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808013846.GO14780@lemon \
--to=famz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).