From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1df1fw-0007JO-Pp for qemu-devel@nongnu.org; Tue, 08 Aug 2017 06:23:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1df1ft-0003mL-Ee for qemu-devel@nongnu.org; Tue, 08 Aug 2017 06:23:48 -0400 Received: from 1.mo4.mail-out.ovh.net ([178.33.248.196]:39753) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1df1ft-0003lu-7x for qemu-devel@nongnu.org; Tue, 08 Aug 2017 06:23:45 -0400 Received: from player694.ha.ovh.net (b6.ovh.net [213.186.33.56]) by mo4.mail-out.ovh.net (Postfix) with ESMTP id C8C688BA06 for ; Tue, 8 Aug 2017 12:23:43 +0200 (CEST) Date: Tue, 8 Aug 2017 12:23:34 +0200 From: Greg Kurz Message-ID: <20170808122334.7f17fe85@bahia.lan> In-Reply-To: <5ee43f17-9797-689e-7c00-99e1375e54f9@kaod.org> References: <20170808060817.2832-1-david@gibson.dropbear.id.au> <20170808060817.2832-2-david@gibson.dropbear.id.au> <5ee43f17-9797-689e-7c00-99e1375e54f9@kaod.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/cGA0MtyoshrFE50Mq0TNIrk"; protocol="application/pgp-signature" Subject: Re: [Qemu-devel] [PATCH for-2.10 1/2] target/ppc: Implement TIDR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?Q8OpZHJpYw==?= Le Goater Cc: David Gibson , mdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, aik@ozlabs.ru, agraf@suse.de --Sig_/cGA0MtyoshrFE50Mq0TNIrk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 8 Aug 2017 11:13:03 +0200 C=C3=A9dric Le Goater wrote: > On 08/08/2017 08:08 AM, David Gibson wrote: > > This adds a trivial implementation of the TIDR register added in > > POWER9. This isn't particularly important to qemu directly - it's > > used by accelerator modules that we don't emulate. > >=20 > > However, since qemu isn't aware of it, its state is not synchronized > > with KVM and therefore not migrated, which can be a problem. =20 >=20 > The Thread ID Register is defined in Power ISA 3.0B. >=20 Indeed. Available here: https://openpowerfoundation.org/?resource_lib=3Dpower-isa-version-3-0 > Reviewed-by: C=C3=A9dric Le Goater >=20 Reviewed-by: Greg Kurz > C.=20 >=20 >=20 > >=20 > > Signed-off-by: David Gibson > > --- > > target/ppc/cpu.h | 1 + > > target/ppc/translate_init.c | 5 +++++ > > 2 files changed, 6 insertions(+) > >=20 > > diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h > > index 6ee2a26a96..f6e5413fad 100644 > > --- a/target/ppc/cpu.h > > +++ b/target/ppc/cpu.h > > @@ -1451,6 +1451,7 @@ void ppc_compat_add_property(Object *obj, const c= har *name, > > #define SPR_TEXASR (0x082) > > #define SPR_TEXASRU (0x083) > > #define SPR_UCTRL (0x088) > > +#define SPR_TIDR (0x090) > > #define SPR_MPC_CMPA (0x090) > > #define SPR_MPC_CMPB (0x091) > > #define SPR_MPC_CMPC (0x092) > > diff --git a/target/ppc/translate_init.c b/target/ppc/translate_init.c > > index 01723bdfec..94800cd29d 100644 > > --- a/target/ppc/translate_init.c > > +++ b/target/ppc/translate_init.c > > @@ -8841,6 +8841,11 @@ static void init_proc_POWER9(CPUPPCState *env) > > gen_spr_power8_book4(env); > > gen_spr_power8_rpr(env); > > =20 > > + /* POWER9 Specific registers */ > > + spr_register_kvm(env, SPR_TIDR, "TIDR", NULL, NULL, > > + spr_read_generic, spr_write_generic, > > + KVM_REG_PPC_TIDR, 0); > > + > > /* env variables */ > > #if !defined(CONFIG_USER_ONLY) > > env->slb_nr =3D 32; > > =20 >=20 --Sig_/cGA0MtyoshrFE50Mq0TNIrk Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlmJkSYACgkQAvw66wEB28JKBgCfYZ1ltliY9hwEWZMisrAUWwRz KzcAn3C6F4CH2gBLcRL5q7PX5fJbJN/5 =fYH1 -----END PGP SIGNATURE----- --Sig_/cGA0MtyoshrFE50Mq0TNIrk--