From: Cornelia Huck <cohuck@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: aneesh.kumar@linux.vnet.ibm.com, borntraeger@de.ibm.com,
agraf@suse.de, thuth@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] 9pfs: fix and simplify dependencies
Date: Tue, 8 Aug 2017 15:00:42 +0200 [thread overview]
Message-ID: <20170808150042.5bf155ae@gondolin> (raw)
In-Reply-To: <20170808145000.3259f597@bahia.lan>
On Tue, 8 Aug 2017 14:50:00 +0200
Greg Kurz <groug@kaod.org> wrote:
> On Tue, 8 Aug 2017 14:17:01 +0200
> Cornelia Huck <cohuck@redhat.com> wrote:
>
> > We want to compile the 9pfs code iff virtfs is enabled and a virtio
> > transport is available (not only pci!).
> >
> > Let's make the generated CONFIG_VIRTFS statement depend on either
> > CONFIG_VIRTIO_PCI or (new) CONFIG_VIRTIO_CCW. The Makefiles for fsdev/
> > and hw/9pfs/ can then depend on CONFIG_VIRTFS directly.
> >
> > Suggested-by: Thomas Huth <thuth@redhat.com>
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
>
> It looks good to me.
>
> Acked-by: Greg Kurz <groug@kaod.org>
>
> > configure | 2 +-
> > default-configs/s390x-softmmu.mak | 1 +
> > fsdev/Makefile.objs | 2 +-
> > hw/Makefile.objs | 2 +-
> > 4 files changed, 4 insertions(+), 3 deletions(-)
Thanks!
Will you queue this yourself, or should I send it together with the
zpci cleanup patches?
next prev parent reply other threads:[~2017-08-08 13:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 12:17 [Qemu-devel] [PATCH 0/1] fixup 9pfs dependencies Cornelia Huck
2017-08-08 12:17 ` [Qemu-devel] [PATCH 1/1] 9pfs: fix and simplify dependencies Cornelia Huck
2017-08-08 12:50 ` Greg Kurz
2017-08-08 13:00 ` Cornelia Huck [this message]
2017-08-08 14:15 ` Greg Kurz
2017-08-08 15:21 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808150042.5bf155ae@gondolin \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).