From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Lukáš Doktor" <ldoktor@redhat.com>
Cc: qemu-devel@nongnu.org, famz@redhat.com, ehabkost@redhat.com,
apahim@redhat.com, armbru@redhat.com, mreitz@redhat.com,
jsnow@redhat.com, f4bug@amsat.org
Subject: Re: [Qemu-devel] [PATCH v4 01/10] qemu.py: Pylint/style fixes
Date: Wed, 9 Aug 2017 11:26:27 +0100 [thread overview]
Message-ID: <20170809102627.GH18003@stefanha-x1.localdomain> (raw)
In-Reply-To: <110c04e3-e676-c705-a6f9-de040208538e@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
On Tue, Aug 08, 2017 at 02:56:47PM +0200, Lukáš Doktor wrote:
> Dne 8.8.2017 v 14:38 Stefan Hajnoczi napsal(a):
> > On Wed, Jul 26, 2017 at 04:42:17PM +0200, Lukáš Doktor wrote:
> >> def command(self, cmd, conv_keys=True, **args):
> >> + '''
> >> + Invoke a QMP command and on success report result dict or on failure
> >
> > s/report/return/ ?
> >
> Don't see much difference, but I'll use the "return" in the next version.
"report" could mean the function logs or prints a message. I have not
heard it used to mean "return".
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-08-09 10:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 14:42 [Qemu-devel] [PATCH v4 00/10] qemu.py: Pylint/style fixes Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 01/10] " Lukáš Doktor
2017-08-03 7:41 ` Lukáš Doktor
2017-08-08 12:38 ` Stefan Hajnoczi
2017-08-08 12:56 ` Lukáš Doktor
2017-08-09 10:26 ` Stefan Hajnoczi [this message]
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 02/10] qemu|qtest: Avoid dangerous arguments Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 03/10] qemu.py: Use iteritems rather than keys() Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 04/10] qemu.py: Simplify QMP key-conversion Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 05/10] qemu.py: Use custom exceptions rather than Exception Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 06/10] qmp.py: Couple of pylint/style fixes Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 07/10] qmp.py: Use object-based class for QEMUMonitorProtocol Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 08/10] qmp.py: Avoid "has_key" usage Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 09/10] qmp.py: Avoid overriding a builtin object Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 10/10] qtest.py: Few pylint/style fixes Lukáš Doktor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809102627.GH18003@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=apahim@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=ldoktor@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).