From: Cornelia Huck <cohuck@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Thomas Huth <thuth@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Graf <agraf@suse.de>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Greg Kurz <groug@kaod.org>
Subject: Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies
Date: Wed, 9 Aug 2017 11:52:11 +0200 [thread overview]
Message-ID: <20170809115211.06dd074e.cohuck@redhat.com> (raw)
In-Reply-To: <CAFEAcA99yzszYLH4rVt4T5h7qJbePkU=TgCJ==nhDU-ogscuDw@mail.gmail.com>
On Wed, 9 Aug 2017 10:47:18 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:
> On 9 August 2017 at 10:07, Thomas Huth <thuth@redhat.com> wrote:
> > While virtio-pci and virtio-ccw seem to require separate dedicated
> > devices (e.g. virtio-9p-pci and virtio-9p-ccw) for everything,
> > virtio-mmio seems to work different. As far as I can see, there are no
> > dedicated virtio-xxx-mmio devices in the code at all. According to
> > https://www.redhat.com/archives/libvir-list/2013-August/msg00009.html
> > you simply have to use virtio-xxx-device here instead. And a
> > virtio-9p-device is available. So theoretically, the 9p code should work
> > with virtio-mmio, too, or is there a problem that I did not see yet?
> >
> > Anyway, we likely should not blindly enable this, so unless somebody has
> > a setup to test it, we should go with your current patch instead, I think.
>
> As you say, we already compile the virtio-9p-device that can
> plug into any virtio transport. So why not just build it
> whenever virtio of any form is enabled? Having it only
> build if PCI is also enabled seems very odd: the backend
> should not care at all about what transport it is using.
Given the previous discussions, I think just dropping the PCI
dependency is indeed the way to go. I'll send a v3.
next prev parent reply other threads:[~2017-08-09 9:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 7:17 [Qemu-devel] [PATCH v2] 9pfs: fix dependencies Cornelia Huck
2017-08-09 8:23 ` Thomas Huth
2017-08-09 8:27 ` Cornelia Huck
2017-08-09 9:07 ` Thomas Huth
2017-08-09 9:13 ` Cornelia Huck
2017-08-09 9:24 ` Daniel P. Berrange
2017-08-09 9:43 ` Cornelia Huck
2017-08-09 9:44 ` Peter Maydell
2017-08-09 9:47 ` Peter Maydell
2017-08-09 9:52 ` Cornelia Huck [this message]
2017-08-09 9:47 ` Greg Kurz
2017-08-09 11:06 ` Cornelia Huck
2017-08-09 12:10 ` Greg Kurz
2017-08-09 16:02 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809115211.06dd074e.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=groug@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).