From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfNf4-0004wW-L2 for qemu-devel@nongnu.org; Wed, 09 Aug 2017 05:52:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dfNf0-0006Dj-J7 for qemu-devel@nongnu.org; Wed, 09 Aug 2017 05:52:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47174) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dfNf0-0006DA-D6 for qemu-devel@nongnu.org; Wed, 09 Aug 2017 05:52:18 -0400 Date: Wed, 9 Aug 2017 11:52:11 +0200 From: Cornelia Huck Message-ID: <20170809115211.06dd074e.cohuck@redhat.com> In-Reply-To: References: <20170809071718.17924-1-cohuck@redhat.com> <20170809102737.18436fb4.cohuck@redhat.com> <5e015c3e-7973-f397-cc1e-fee190292616@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Thomas Huth , QEMU Developers , Christian Borntraeger , Alexander Graf , "Aneesh Kumar K.V" , Greg Kurz On Wed, 9 Aug 2017 10:47:18 +0100 Peter Maydell wrote: > On 9 August 2017 at 10:07, Thomas Huth wrote: > > While virtio-pci and virtio-ccw seem to require separate dedicated > > devices (e.g. virtio-9p-pci and virtio-9p-ccw) for everything, > > virtio-mmio seems to work different. As far as I can see, there are no > > dedicated virtio-xxx-mmio devices in the code at all. According to > > https://www.redhat.com/archives/libvir-list/2013-August/msg00009.html > > you simply have to use virtio-xxx-device here instead. And a > > virtio-9p-device is available. So theoretically, the 9p code should work > > with virtio-mmio, too, or is there a problem that I did not see yet? > > > > Anyway, we likely should not blindly enable this, so unless somebody has > > a setup to test it, we should go with your current patch instead, I think. > > As you say, we already compile the virtio-9p-device that can > plug into any virtio transport. So why not just build it > whenever virtio of any form is enabled? Having it only > build if PCI is also enabled seems very odd: the backend > should not care at all about what transport it is using. Given the previous discussions, I think just dropping the PCI dependency is indeed the way to go. I'll send a v3.