From: Cornelia Huck <cohuck@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: Thomas Huth <thuth@redhat.com>,
aneesh.kumar@linux.vnet.ibm.com, borntraeger@de.ibm.com,
agraf@suse.de, qemu-devel@nongnu.org,
Stefano Stabellini <sstabellini@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies
Date: Wed, 9 Aug 2017 13:06:14 +0200 [thread overview]
Message-ID: <20170809130608.3ce61bd3.cohuck@redhat.com> (raw)
In-Reply-To: <20170809114705.39dc0455@bahia.lan>
On Wed, 9 Aug 2017 11:47:05 +0200
Greg Kurz <groug@kaod.org> wrote:
> On Wed, 9 Aug 2017 10:27:37 +0200
> Cornelia Huck <cohuck@redhat.com> wrote:
>
> > On Wed, 9 Aug 2017 10:23:04 +0200
> > Thomas Huth <thuth@redhat.com> wrote:
> > > But thinking about this again, I wonder whether it would be enough to
> > > simply check for CONFIG_VIRTIO=y here instead. CONFIG_VIRTIO=y should be
> > > sufficient to assert that there is also at least one kind of virtio
> > > transport available, right?
> > > Otherwise this will look really horrible as soon as somebody also tries
> > > to add support for virtio-mmio here later ;-)
> >
>
> And virtio isn't the only transport for 9p: we also have a Xen backend,
> which happen to be built because targets that support Xen also have
> CONFIG_PCI I guess.
Only if they also have virtio enabled, no?
Should the condition be VIRTFS && (VIRTIO || XEN), then?
next prev parent reply other threads:[~2017-08-09 11:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 7:17 [Qemu-devel] [PATCH v2] 9pfs: fix dependencies Cornelia Huck
2017-08-09 8:23 ` Thomas Huth
2017-08-09 8:27 ` Cornelia Huck
2017-08-09 9:07 ` Thomas Huth
2017-08-09 9:13 ` Cornelia Huck
2017-08-09 9:24 ` Daniel P. Berrange
2017-08-09 9:43 ` Cornelia Huck
2017-08-09 9:44 ` Peter Maydell
2017-08-09 9:47 ` Peter Maydell
2017-08-09 9:52 ` Cornelia Huck
2017-08-09 9:47 ` Greg Kurz
2017-08-09 11:06 ` Cornelia Huck [this message]
2017-08-09 12:10 ` Greg Kurz
2017-08-09 16:02 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809130608.3ce61bd3.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=groug@kaod.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).