From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfTRH-0002gK-Qn for qemu-devel@nongnu.org; Wed, 09 Aug 2017 12:02:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dfTRG-0007K8-TP for qemu-devel@nongnu.org; Wed, 09 Aug 2017 12:02:31 -0400 From: Stefan Hajnoczi Date: Wed, 9 Aug 2017 17:02:11 +0100 Message-Id: <20170809160212.29976-2-stefanha@redhat.com> In-Reply-To: <20170809160212.29976-1-stefanha@redhat.com> References: <20170809160212.29976-1-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] IDE: Do not flush empty CDROM drives List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: P J P , Kevin Wolf , Eric Blake , qemu-block@nongnu.org, Paolo Bonzini , John Snow , "Dr . David Alan Gilbert" , Stefan Hajnoczi The block backend changed in a way that flushing empty CDROM drives now crashes. Amend IDE to avoid doing so until the root problem can be addressed for 2.11. Original patch by John Snow . Reported-by: Kieron Shorrock Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 0b48b64d3a..bea39536b0 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1063,7 +1063,15 @@ static void ide_flush_cache(IDEState *s) s->status |= BUSY_STAT; ide_set_retry(s); block_acct_start(blk_get_stats(s->blk), &s->acct, 0, BLOCK_ACCT_FLUSH); - s->pio_aiocb = blk_aio_flush(s->blk, ide_flush_cb, s); + + if (blk_bs(s->blk)) { + s->pio_aiocb = blk_aio_flush(s->blk, ide_flush_cb, s); + } else { + /* XXX blk_aio_flush() crashes when blk_bs(blk) is NULL, remove this + * temporary workaround when blk_aio_*() functions handle NULL blk_bs. + */ + ide_flush_cb(s, 0); + } } static void ide_cfata_metadata_inquiry(IDEState *s) -- 2.13.3