Re: [Qemu-devel] [PATCH v4 5/7] block: add throttle block filter driver

[Manos Pitsidianakis <el13635@mail.ntua.gr>]

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

On Wed, Aug 09, 2017 at 01:07:32PM +0300, Manos Pitsidianakis wrote:
>+static int coroutine_fn throttle_co_preadv(BlockDriverState *bs,
>+                                           uint64_t offset, uint64_t bytes,
>+                                           QEMUIOVector *qiov, int flags)
>+{
>+
>+    ThrottleGroupMember *tgm = bs->opaque;
>+    throttle_group_co_io_limits_intercept(tgm, bytes, false);
>+
>+    return bdrv_co_preadv(bs->file, offset, bytes, qiov, flags);
>+}
>+
>+static int coroutine_fn throttle_co_pwritev(BlockDriverState *bs,
>+                                            uint64_t offset, uint64_t bytes,
>+                                            QEMUIOVector *qiov, int flags)
>+{
>+    ThrottleGroupMember *tgm = bs->opaque;
>+    throttle_group_co_io_limits_intercept(tgm, bytes, true);
>+
>+    return bdrv_co_preadv(bs->file, offset, bytes, qiov, flags);
--------------------^
Tried some write throttling testing, noticed this. If anyone wants to
test this iteration, change this to bdrv_co_pwritev(), I will correct
this in the next version. (let's pretend this never happened!)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]