* [Qemu-devel] [PATCH v2] boot-serial-test: fallback to kvm accelerator
@ 2017-08-11 13:18 Cornelia Huck
2017-08-11 13:29 ` Daniel P. Berrange
2017-08-11 13:32 ` Thomas Huth
0 siblings, 2 replies; 5+ messages in thread
From: Cornelia Huck @ 2017-08-11 13:18 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth, pbonzini, Cornelia Huck
Currently, at least x86_64 and s390x support building with --disable-tcg.
Instead of forcing tcg (which causes the test to fail on such builds),
allow to use kvm as well.
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
v1->v2: switch around kvm and tcg
Added Paolo on cc:; I can still take this through the s390x tree, though.
---
tests/boot-serial-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
index 11f48b049c..78303b14ce 100644
--- a/tests/boot-serial-test.c
+++ b/tests/boot-serial-test.c
@@ -78,7 +78,8 @@ static void test_machine(const void *data)
fd = mkstemp(tmpname);
g_assert(fd != -1);
- args = g_strdup_printf("-M %s,accel=tcg -chardev file,id=serial0,path=%s"
+ args = g_strdup_printf("-M %s,accel=kvm:tcg "
+ "-chardev file,id=serial0,path=%s"
" -no-shutdown -serial chardev:serial0 %s",
test->machine, tmpname, test->extra);
--
2.13.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH v2] boot-serial-test: fallback to kvm accelerator
2017-08-11 13:18 [Qemu-devel] [PATCH v2] boot-serial-test: fallback to kvm accelerator Cornelia Huck
@ 2017-08-11 13:29 ` Daniel P. Berrange
2017-08-11 13:34 ` Cornelia Huck
2017-08-11 13:32 ` Thomas Huth
1 sibling, 1 reply; 5+ messages in thread
From: Daniel P. Berrange @ 2017-08-11 13:29 UTC (permalink / raw)
To: Cornelia Huck; +Cc: qemu-devel, pbonzini, thuth
On Fri, Aug 11, 2017 at 03:18:01PM +0200, Cornelia Huck wrote:
> Currently, at least x86_64 and s390x support building with --disable-tcg.
> Instead of forcing tcg (which causes the test to fail on such builds),
> allow to use kvm as well.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>
> v1->v2: switch around kvm and tcg
>
> Added Paolo on cc:; I can still take this through the s390x tree, though.
>
> ---
> tests/boot-serial-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
> index 11f48b049c..78303b14ce 100644
> --- a/tests/boot-serial-test.c
> +++ b/tests/boot-serial-test.c
> @@ -78,7 +78,8 @@ static void test_machine(const void *data)
> fd = mkstemp(tmpname);
> g_assert(fd != -1);
>
> - args = g_strdup_printf("-M %s,accel=tcg -chardev file,id=serial0,path=%s"
> + args = g_strdup_printf("-M %s,accel=kvm:tcg "
> + "-chardev file,id=serial0,path=%s"
> " -no-shutdown -serial chardev:serial0 %s",
> test->machine, tmpname, test->extra);
Total nit-pick - the first line has a trailing ' ', while the second
line has no leading or trailing ' ', and the third line has a leading
' '. The inconsistency bugs me - suggest using trailing ' ' in both
lines. No need to repost for that though, fine if it is touched up
for the PULL, so
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH v2] boot-serial-test: fallback to kvm accelerator
2017-08-11 13:29 ` Daniel P. Berrange
@ 2017-08-11 13:34 ` Cornelia Huck
2017-08-11 13:35 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Cornelia Huck @ 2017-08-11 13:34 UTC (permalink / raw)
To: Daniel P. Berrange; +Cc: qemu-devel, pbonzini, thuth
On Fri, 11 Aug 2017 14:29:53 +0100
"Daniel P. Berrange" <berrange@redhat.com> wrote:
> On Fri, Aug 11, 2017 at 03:18:01PM +0200, Cornelia Huck wrote:
> > Currently, at least x86_64 and s390x support building with --disable-tcg.
> > Instead of forcing tcg (which causes the test to fail on such builds),
> > allow to use kvm as well.
> >
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> >
> > v1->v2: switch around kvm and tcg
> >
> > Added Paolo on cc:; I can still take this through the s390x tree, though.
> >
> > ---
> > tests/boot-serial-test.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
> > index 11f48b049c..78303b14ce 100644
> > --- a/tests/boot-serial-test.c
> > +++ b/tests/boot-serial-test.c
> > @@ -78,7 +78,8 @@ static void test_machine(const void *data)
> > fd = mkstemp(tmpname);
> > g_assert(fd != -1);
> >
> > - args = g_strdup_printf("-M %s,accel=tcg -chardev file,id=serial0,path=%s"
> > + args = g_strdup_printf("-M %s,accel=kvm:tcg "
> > + "-chardev file,id=serial0,path=%s"
> > " -no-shutdown -serial chardev:serial0 %s",
> > test->machine, tmpname, test->extra);
>
> Total nit-pick - the first line has a trailing ' ', while the second
> line has no leading or trailing ' ', and the third line has a leading
> ' '. The inconsistency bugs me - suggest using trailing ' ' in both
> lines.
Yes, I prefer trailing ' ' as well, just did not want to touch more
lines than necessary.
> No need to repost for that though, fine if it is touched up
> for the PULL, so
>
> Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH v2] boot-serial-test: fallback to kvm accelerator
2017-08-11 13:34 ` Cornelia Huck
@ 2017-08-11 13:35 ` Paolo Bonzini
0 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2017-08-11 13:35 UTC (permalink / raw)
To: Cornelia Huck, Daniel P. Berrange; +Cc: qemu-devel, thuth
On 11/08/2017 15:34, Cornelia Huck wrote:
> On Fri, 11 Aug 2017 14:29:53 +0100
> "Daniel P. Berrange" <berrange@redhat.com> wrote:
>
>> On Fri, Aug 11, 2017 at 03:18:01PM +0200, Cornelia Huck wrote:
>>> Currently, at least x86_64 and s390x support building with --disable-tcg.
>>> Instead of forcing tcg (which causes the test to fail on such builds),
>>> allow to use kvm as well.
>>>
>>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>>> ---
>>>
>>> v1->v2: switch around kvm and tcg
>>>
>>> Added Paolo on cc:; I can still take this through the s390x tree, though.
>>>
>>> ---
>>> tests/boot-serial-test.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
>>> index 11f48b049c..78303b14ce 100644
>>> --- a/tests/boot-serial-test.c
>>> +++ b/tests/boot-serial-test.c
>>> @@ -78,7 +78,8 @@ static void test_machine(const void *data)
>>> fd = mkstemp(tmpname);
>>> g_assert(fd != -1);
>>>
>>> - args = g_strdup_printf("-M %s,accel=tcg -chardev file,id=serial0,path=%s"
>>> + args = g_strdup_printf("-M %s,accel=kvm:tcg "
>>> + "-chardev file,id=serial0,path=%s"
>>> " -no-shutdown -serial chardev:serial0 %s",
>>> test->machine, tmpname, test->extra);
>>
>> Total nit-pick - the first line has a trailing ' ', while the second
>> line has no leading or trailing ' ', and the third line has a leading
>> ' '. The inconsistency bugs me - suggest using trailing ' ' in both
>> lines.
>
> Yes, I prefer trailing ' ' as well, just did not want to touch more
> lines than necessary.
Go ahead and fix it + send the pull request yourself.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] boot-serial-test: fallback to kvm accelerator
2017-08-11 13:18 [Qemu-devel] [PATCH v2] boot-serial-test: fallback to kvm accelerator Cornelia Huck
2017-08-11 13:29 ` Daniel P. Berrange
@ 2017-08-11 13:32 ` Thomas Huth
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2017-08-11 13:32 UTC (permalink / raw)
To: Cornelia Huck, qemu-devel; +Cc: pbonzini
On 11.08.2017 15:18, Cornelia Huck wrote:
> Currently, at least x86_64 and s390x support building with --disable-tcg.
> Instead of forcing tcg (which causes the test to fail on such builds),
> allow to use kvm as well.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>
> v1->v2: switch around kvm and tcg
>
> Added Paolo on cc:; I can still take this through the s390x tree, though.
>
> ---
> tests/boot-serial-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
> index 11f48b049c..78303b14ce 100644
> --- a/tests/boot-serial-test.c
> +++ b/tests/boot-serial-test.c
> @@ -78,7 +78,8 @@ static void test_machine(const void *data)
> fd = mkstemp(tmpname);
> g_assert(fd != -1);
>
> - args = g_strdup_printf("-M %s,accel=tcg -chardev file,id=serial0,path=%s"
> + args = g_strdup_printf("-M %s,accel=kvm:tcg "
> + "-chardev file,id=serial0,path=%s"
> " -no-shutdown -serial chardev:serial0 %s",
> test->machine, tmpname, test->extra);
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-11 13:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-11 13:18 [Qemu-devel] [PATCH v2] boot-serial-test: fallback to kvm accelerator Cornelia Huck
2017-08-11 13:29 ` Daniel P. Berrange
2017-08-11 13:34 ` Cornelia Huck
2017-08-11 13:35 ` Paolo Bonzini
2017-08-11 13:32 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).