From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, rth@twiddle.net,
Aurelien Jarno <aurelien@aurel32.net>,
thuth@redhat.com, borntraeger@de.ibm.com
Subject: Re: [Qemu-devel] [PATCH RFC 0/5] target/s390x: introduce internal.h and cleanup cpu.h
Date: Fri, 11 Aug 2017 17:15:15 +0200 [thread overview]
Message-ID: <20170811171515.623cd5c6.cohuck@redhat.com> (raw)
In-Reply-To: <20170811074652.31474-1-david@redhat.com>
On Fri, 11 Aug 2017 09:46:47 +0200
David Hildenbrand <david@redhat.com> wrote:
> cpu.h is accessed outside of target/s390x. It should only contain
> what is expected to be accessed outside of this folder. Therefore, create
> internal.h and move a lot to that file.
Cool, I like that.
>
> While doing that, I noticed that a lot of function prototypes not
> available with CONFIG_USER_ONLY are not protected by CONFIG_USER_ONLY.
>
> As these CONFIG_USER_ONLY are in general ugly, I decided to minimize
> them to the bare minimum :]. Do we care? I dropped it wherever possible.
>
> My compiler doesn't bail out, so let's see what the bot says.
That should be easy to fix :)
>
> There is still a lot to clean up (e.g. do we want kvm-stub.c ?). This is
> the first step.
Do you plan to send a v2 with kvm_s390x.h? If yes, I'll hold off
looking at this series.
next prev parent reply other threads:[~2017-08-11 15:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 7:46 [Qemu-devel] [PATCH RFC 0/5] target/s390x: introduce internal.h and cleanup cpu.h David Hildenbrand
2017-08-11 7:46 ` [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h David Hildenbrand
2017-08-11 13:15 ` Richard Henderson
2017-08-11 13:21 ` David Hildenbrand
2017-08-11 14:00 ` Thomas Huth
2017-08-11 14:21 ` David Hildenbrand
2017-08-11 14:39 ` Thomas Huth
2017-08-11 16:11 ` David Hildenbrand
2017-08-11 16:29 ` Thomas Huth
2017-08-11 14:14 ` Thomas Huth
2017-08-11 14:16 ` David Hildenbrand
2017-08-11 7:46 ` [Qemu-devel] [PATCH RFC 2/5] target/s390x: move a couple of functions to cpu.c David Hildenbrand
2017-08-11 13:17 ` Richard Henderson
2017-08-11 14:09 ` Thomas Huth
2017-08-11 7:46 ` [Qemu-devel] [PATCH RFC 3/5] s390x: avoid calling kvm_ functions outside of target/s390x/ David Hildenbrand
2017-08-11 13:18 ` Richard Henderson
2017-08-11 14:19 ` Thomas Huth
2017-08-11 7:46 ` [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h David Hildenbrand
2017-08-11 13:19 ` Richard Henderson
2017-08-11 14:19 ` Thomas Huth
2017-08-11 16:11 ` David Hildenbrand
2017-08-11 17:18 ` Richard Henderson
2017-08-11 18:42 ` David Hildenbrand
2017-08-11 7:46 ` [Qemu-devel] [PATCH RFC 5/5] target/s390x: cleanup cpu.h David Hildenbrand
2017-08-11 13:20 ` Richard Henderson
2017-08-11 8:04 ` [Qemu-devel] [PATCH RFC 0/5] target/s390x: introduce internal.h and " no-reply
2017-08-11 8:53 ` David Hildenbrand
2017-08-11 15:15 ` Cornelia Huck [this message]
2017-08-11 15:30 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811171515.623cd5c6.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).