From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgBeq-0008FS-NM for qemu-devel@nongnu.org; Fri, 11 Aug 2017 11:15:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgBel-0002Kf-Ok for qemu-devel@nongnu.org; Fri, 11 Aug 2017 11:15:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40466) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dgBel-0002IV-J5 for qemu-devel@nongnu.org; Fri, 11 Aug 2017 11:15:23 -0400 Date: Fri, 11 Aug 2017 17:15:15 +0200 From: Cornelia Huck Message-ID: <20170811171515.623cd5c6.cohuck@redhat.com> In-Reply-To: <20170811074652.31474-1-david@redhat.com> References: <20170811074652.31474-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 0/5] target/s390x: introduce internal.h and cleanup cpu.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-devel@nongnu.org, rth@twiddle.net, Aurelien Jarno , thuth@redhat.com, borntraeger@de.ibm.com On Fri, 11 Aug 2017 09:46:47 +0200 David Hildenbrand wrote: > cpu.h is accessed outside of target/s390x. It should only contain > what is expected to be accessed outside of this folder. Therefore, create > internal.h and move a lot to that file. Cool, I like that. > > While doing that, I noticed that a lot of function prototypes not > available with CONFIG_USER_ONLY are not protected by CONFIG_USER_ONLY. > > As these CONFIG_USER_ONLY are in general ugly, I decided to minimize > them to the bare minimum :]. Do we care? I dropped it wherever possible. > > My compiler doesn't bail out, so let's see what the bot says. That should be easy to fix :) > > There is still a lot to clean up (e.g. do we want kvm-stub.c ?). This is > the first step. Do you plan to send a v2 with kvm_s390x.h? If yes, I'll hold off looking at this series.