qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: wei.yang@ucloud.cn
To: mst@redhat.com, imammedo@redhat.com
Cc: qemu-devel@nongnu.org, wei.yang@ucloud.cn
Subject: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name
Date: Mon, 14 Aug 2017 16:48:38 +0800	[thread overview]
Message-ID: <20170814084838.12233-1-wei.yang@ucloud.cn> (raw)

From: Wei Yang <wei.yang@ucloud.cn>

The assert would be touched when the version of acpica is greater than or
equal to 20160318. its reason is that "Disasembler: Update a couple
output items(commit id: 1ecbb3d)" is introduced by Robert, the patch
emits the AML filename as a zero-length string, and allows the compiler
to create the name later.

Signed-off-by: Yang, Wei <wei.yang@ucloud.com>
CC: Michael S. Tsirkin <mst@redhat.com>
CC: Igor Mammedov <imammedo@redhat.com>
CC: qemu-devel@nongnu.org
---
 tests/bios-tables-test.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index 88dbf97853..d2ab073848 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -350,7 +350,6 @@ static GString *normalize_asl(gchar *asl_code)
     /* strip def block name (it has file path in it) */
     if (g_str_has_prefix(asl->str, DEF_BLOCK)) {
         block_name = g_strstr_len(asl->str, asl->len, BLOCK_NAME_END);
-        g_assert(block_name);
         asl = g_string_erase(asl, 0,
                              block_name + sizeof(BLOCK_NAME_END) - asl->str);
     }
-- 
2.11.0

             reply	other threads:[~2017-08-14  9:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14  8:48 wei.yang [this message]
2017-08-14 15:58 ` [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name Michael S. Tsirkin
2017-08-15  2:21   ` wyang
2017-08-15  2:39     ` Michael S. Tsirkin
2017-08-15  2:46       ` wyang
2017-08-15  2:49         ` Michael S. Tsirkin
2017-08-15  3:53           ` wyang
2017-08-15  4:06             ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170814084838.12233-1-wei.yang@ucloud.cn \
    --to=wei.yang@ucloud.cn \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).