qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Eric Blake <eblake@redhat.com>,
	"Daniel P. Berrange" <berrange@redhat.com>
Subject: [Qemu-devel] [PATCH v2 03/12] ui: convert key events to QKeyCodes immediately
Date: Mon, 14 Aug 2017 11:49:49 +0100	[thread overview]
Message-ID: <20170814104958.29434-4-berrange@redhat.com> (raw)
In-Reply-To: <20170814104958.29434-1-berrange@redhat.com>

Always use QKeyCode in the InputKeyEvent struct, by converting key
numbers to QKeyCode at the time the event is created.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 ui/input.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/ui/input.c b/ui/input.c
index af05f06368..64e9103a61 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -400,10 +400,8 @@ void qemu_input_event_send_key(QemuConsole *src, KeyValue *key, bool down)
 
 void qemu_input_event_send_key_number(QemuConsole *src, int num, bool down)
 {
-    KeyValue *key = g_new0(KeyValue, 1);
-    key->type = KEY_VALUE_KIND_NUMBER;
-    key->u.number.data = num;
-    qemu_input_event_send_key(src, key, down);
+    QKeyCode code = qemu_input_key_number_to_qcode(num);
+    qemu_input_event_send_key_qcode(src, code, down);
 }
 
 void qemu_input_event_send_key_qcode(QemuConsole *src, QKeyCode q, bool down)
-- 
2.13.3

  parent reply	other threads:[~2017-08-14 10:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14 10:49 [Qemu-devel] [PATCH v2 00/12] Convert over to use keycodemapdb Daniel P. Berrange
2017-08-14 10:49 ` [Qemu-devel] [PATCH v2 01/12] ui: add keycodemapdb repository as a GIT submodule Daniel P. Berrange
2017-08-14 10:49 ` [Qemu-devel] [PATCH v2 02/12] ui: convert common input code to keycodemapdb Daniel P. Berrange
2017-08-14 10:49 ` Daniel P. Berrange [this message]
2017-08-14 10:49 ` [Qemu-devel] [PATCH v2 04/12] ui: don't export qemu_input_event_new_key Daniel P. Berrange
2017-08-14 10:49 ` [Qemu-devel] [PATCH v2 05/12] input: convert virtio-input-hid device to keycodemapdb Daniel P. Berrange
2017-08-14 10:49 ` [Qemu-devel] [PATCH v2 06/12] input: convert ps2 " Daniel P. Berrange
2017-08-14 10:49 ` [Qemu-devel] [PATCH v2 07/12] input: convert the adb " Daniel P. Berrange
2017-08-14 10:49 ` [Qemu-devel] [PATCH v2 08/12] char: convert the escc " Daniel P. Berrange
2017-08-14 10:49 ` [Qemu-devel] [PATCH v2 09/12] ui: convert cocoa frontend " Daniel P. Berrange
2017-08-14 10:49 ` [Qemu-devel] [PATCH v2 10/12] ui: convert the SDL2 " Daniel P. Berrange
2017-08-14 10:49 ` [Qemu-devel] [PATCH v2 11/12] ui: convert GTK and SDL1 frontends " Daniel P. Berrange
2017-08-14 10:49 ` [Qemu-devel] [PATCH v2 12/12] display: convert XenInput keyboard " Daniel P. Berrange
2017-08-14 11:03 ` [Qemu-devel] [PATCH v2 00/12] Convert over to use keycodemapdb no-reply
2017-08-14 11:04 ` no-reply
2017-08-14 11:04 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170814104958.29434-4-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).