From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhCwr-0007Yy-Qt for qemu-devel@nongnu.org; Mon, 14 Aug 2017 06:50:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhCwq-0001ug-S7 for qemu-devel@nongnu.org; Mon, 14 Aug 2017 06:50:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55414) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhCwq-0001uX-Mi for qemu-devel@nongnu.org; Mon, 14 Aug 2017 06:50:16 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 985286F188 for ; Mon, 14 Aug 2017 10:50:15 +0000 (UTC) From: "Daniel P. Berrange" Date: Mon, 14 Aug 2017 11:49:49 +0100 Message-Id: <20170814104958.29434-4-berrange@redhat.com> In-Reply-To: <20170814104958.29434-1-berrange@redhat.com> References: <20170814104958.29434-1-berrange@redhat.com> Subject: [Qemu-devel] [PATCH v2 03/12] ui: convert key events to QKeyCodes immediately List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Eric Blake , "Daniel P. Berrange" Always use QKeyCode in the InputKeyEvent struct, by converting key numbers to QKeyCode at the time the event is created. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- ui/input.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/input.c b/ui/input.c index af05f06368..64e9103a61 100644 --- a/ui/input.c +++ b/ui/input.c @@ -400,10 +400,8 @@ void qemu_input_event_send_key(QemuConsole *src, KeyValue *key, bool down) void qemu_input_event_send_key_number(QemuConsole *src, int num, bool down) { - KeyValue *key = g_new0(KeyValue, 1); - key->type = KEY_VALUE_KIND_NUMBER; - key->u.number.data = num; - qemu_input_event_send_key(src, key, down); + QKeyCode code = qemu_input_key_number_to_qcode(num); + qemu_input_event_send_key_qcode(src, code, down); } void qemu_input_event_send_key_qcode(QemuConsole *src, QKeyCode q, bool down) -- 2.13.3