From: Fam Zheng <famz@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] Makefile: Let "make check-help" work without running ./configure
Date: Tue, 15 Aug 2017 15:09:27 +0800 [thread overview]
Message-ID: <20170815070927.GB29320@lemon> (raw)
In-Reply-To: <0d899b2a-19a0-5b52-c63e-dba8b1d2d851@amsat.org>
On Thu, 08/10 08:59, Philippe Mathieu-Daudé wrote:
> Hi Fam,
>
> thank for fixing this :)
>
> I think as a bugfix it should enter 2.10
> (maybe through Alex's Travis series, CC'ing him)
Since Alex hasn't replied, I'll send a pull request for -rc3.
>
> On 08/10/2017 05:50 AM, Fam Zheng wrote:
> > Currently if you do "make check-help" in a fresh checkout, only an error
> > is printed which is not nice:
> >
> > $ make check-help V=1
> > cc -nostdlib -o check-help.mo
> > cc: fatal error: no input files
> > compilation terminated.
> > rules.mak:115: recipe for target 'check-help.mo' failed
> > make: *** [check-help.mo] Error 1
> >
> > Move the config-host.mak condition into the body of
> > tests/Makefile.include and always include the rule for check-help.
> >
> > Reported-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > Signed-off-by: Fam Zheng <famz@redhat.com>
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
Fam
next prev parent reply other threads:[~2017-08-15 7:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 8:50 [Qemu-devel] [PATCH] Makefile: Let "make check-help" work without running ./configure Fam Zheng
2017-08-10 11:59 ` Philippe Mathieu-Daudé
2017-08-15 7:09 ` Fam Zheng [this message]
2017-08-15 9:32 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815070927.GB29320@lemon \
--to=famz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).