From: "Lukáš Doktor" <ldoktor@redhat.com>
To: qemu-devel@nongnu.org
Cc: ldoktor@redhat.com, famz@redhat.com, ehabkost@redhat.com,
apahim@redhat.com, armbru@redhat.com, mreitz@redhat.com,
jsnow@redhat.com, f4bug@amsat.org
Subject: [Qemu-devel] [PATCH v5 04/10] qemu.py: Simplify QMP key-conversion
Date: Tue, 15 Aug 2017 10:57:26 +0200 [thread overview]
Message-ID: <20170815085732.9794-5-ldoktor@redhat.com> (raw)
In-Reply-To: <20170815085732.9794-1-ldoktor@redhat.com>
The QMP key conversion consist of '_'s to be replaced with '-'s, which
can easily be done by a single `str.replace` method which is faster and
does not require `string` module import.
Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
---
scripts/qemu.py | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 571f852..5ba17d0 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -13,7 +13,6 @@
#
import errno
-import string
import os
import sys
import subprocess
@@ -180,14 +179,12 @@ class QEMUMachine(object):
self._load_io_log()
self._post_shutdown()
- underscore_to_dash = string.maketrans('_', '-')
-
def qmp(self, cmd, conv_keys=True, **args):
'''Invoke a QMP command and return the result dict'''
qmp_args = dict()
for key, value in args.iteritems():
if conv_keys:
- qmp_args[key.translate(self.underscore_to_dash)] = value
+ qmp_args[key.replace('_', '-')] = value
else:
qmp_args[key] = value
--
2.9.4
next prev parent reply other threads:[~2017-08-15 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 8:57 [Qemu-devel] [PATCH v5 00/10] qemu.py: Pylint/style fixes Lukáš Doktor
2017-08-15 8:57 ` [Qemu-devel] [PATCH v5 01/10] " Lukáš Doktor
2017-08-15 11:55 ` Stefan Hajnoczi
2017-08-15 12:31 ` Markus Armbruster
2017-08-16 16:01 ` Lukáš Doktor
2017-08-16 16:58 ` Markus Armbruster
2017-08-16 17:48 ` Lukáš Doktor
2017-08-17 5:24 ` Markus Armbruster
2017-08-17 18:16 ` Lukáš Doktor
2017-08-15 8:57 ` [Qemu-devel] [PATCH v5 02/10] qemu|qtest: Avoid dangerous arguments Lukáš Doktor
2017-08-15 8:57 ` [Qemu-devel] [PATCH v5 03/10] qemu.py: Use iteritems rather than keys() Lukáš Doktor
2017-08-15 8:57 ` Lukáš Doktor [this message]
2017-08-15 8:57 ` [Qemu-devel] [PATCH v5 05/10] qemu.py: Use custom exceptions rather than Exception Lukáš Doktor
2017-08-15 8:57 ` [Qemu-devel] [PATCH v5 06/10] qmp.py: Couple of pylint/style fixes Lukáš Doktor
2017-08-15 8:57 ` [Qemu-devel] [PATCH v5 07/10] qmp.py: Use object-based class for QEMUMonitorProtocol Lukáš Doktor
2017-08-15 8:57 ` [Qemu-devel] [PATCH v5 08/10] qmp.py: Avoid "has_key" usage Lukáš Doktor
2017-08-15 8:57 ` [Qemu-devel] [PATCH v5 09/10] qmp.py: Avoid overriding a builtin object Lukáš Doktor
2017-08-15 8:57 ` [Qemu-devel] [PATCH v5 10/10] qtest.py: Few pylint/style fixes Lukáš Doktor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815085732.9794-5-ldoktor@redhat.com \
--to=ldoktor@redhat.com \
--cc=apahim@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).