From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhYhy-0003I6-Pj for qemu-devel@nongnu.org; Tue, 15 Aug 2017 06:04:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhYhu-00028J-UF for qemu-devel@nongnu.org; Tue, 15 Aug 2017 06:04:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44754) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhYhu-00027v-Oo for qemu-devel@nongnu.org; Tue, 15 Aug 2017 06:04:18 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BAE096B36A for ; Tue, 15 Aug 2017 10:04:17 +0000 (UTC) Date: Tue, 15 Aug 2017 11:04:10 +0100 From: "Daniel P. Berrange" Message-ID: <20170815100410.GH9674@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170815093615.16453-1-berrange@redhat.com> <20170815093615.16453-2-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170815093615.16453-2-berrange@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 01/12] ui: add keycodemapdb repository as a GIT submodule List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Eric Blake On Tue, Aug 15, 2017 at 10:36:04AM +0100, Daniel P. Berrange wrote: > The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a > data file mapping between all the different scancode/keycode/keysym > sets that are known, and a tool to auto-generate lookup tables for > different combinations. > > It is used by GTK-VNC, SPICE-GTK and libvirt for mapping keys. > Using it in QEMU will let us replace many hand written lookup > tables with auto-generated tables from a master data source, > reducing bugs. Adding new QKeyCodes will now only require the > master table to be updated, all ~20 other tables will be > automatically updated to follow. > > Signed-off-by: Daniel P. Berrange > --- > .gitignore | 2 ++ > .gitmodules | 3 +++ > configure | 2 ++ > tests/docker/Makefile.include | 11 +++++++---- > tests/docker/run | 4 +++- > ui/Makefile.objs | 18 ++++++++++++++++++ > ui/keycodemapdb | 1 + > 7 files changed, 36 insertions(+), 5 deletions(-) > create mode 160000 ui/keycodemapdb > > diff --git a/configure b/configure > index dd73cce62f..bd373ec2b4 100755 > --- a/configure > +++ b/configure > @@ -5258,6 +5258,8 @@ echo_version() { > fi > } > > +(cd $source_path && git submodule update --init ui/keycodemapdb) > + Urgh, no, this won't work because of course you don't have to have a git checkout when running configure. Any suggestions on the "best" way to ensure that the ui/keycodemapdb git submodule is always checked out, without requiring developers to do something manually ? I could try (cd $source_path && test -d .git && git submodule update --init ui/keycodemapdb) but wonder if there's a better way ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|