qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, alistair.francis@xilinx.com,
	edgar.iglesias@xilinx.com
Subject: [Qemu-devel] [PATCH v2 for-2.10 0/3] Fixup logic for exclusive pair
Date: Tue, 15 Aug 2017 07:57:11 -0700	[thread overview]
Message-ID: <20170815145714.17635-1-richard.henderson@linaro.org> (raw)

In reviewing my previous patch, Peter pointed out that it is
CONSTRAINED UNPREDICTABLE what happens when you mix the number
of registers in a LDX[PR] + STX[RP] pair.  So most of the bug
that I thought that I was fixing isn't a bug at all.

That said, the patch does still fix a real bug wrt single-copy
semantics, so patch 2 is largely unchanged; the commit message
is re-worded.

I also un-squashed Alistair's original patches and dropped the
tcg/tcg-op.c change, to be revisited for 2.11.


r~


Alistair Francis (2):
  target/arm: Correct exclusive store cmpxchg memop mask
  target/arm: Require alignment for load exclusive

Richard Henderson (1):
  target/arm: Correct load exclusive pair atomicity

 target/arm/translate-a64.c | 63 ++++++++++++++++++++++++++++------------------
 1 file changed, 39 insertions(+), 24 deletions(-)

-- 
2.13.4

             reply	other threads:[~2017-08-15 14:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15 14:57 Richard Henderson [this message]
2017-08-15 14:57 ` [Qemu-devel] [PATCH v2 for-2.10 1/3] target/arm: Correct exclusive store cmpxchg memop mask Richard Henderson
2017-08-15 15:41   ` Philippe Mathieu-Daudé
2017-08-15 16:21     ` Alistair Francis
2017-08-15 14:57 ` [Qemu-devel] [PATCH v2 for-2.10 2/3] target/arm: Correct load exclusive pair atomicity Richard Henderson
2017-08-15 14:57 ` [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive Richard Henderson
2017-08-15 15:27   ` Eric Blake
2017-08-15 15:56   ` Philippe Mathieu-Daudé
2017-08-15 16:14     ` Peter Maydell
2017-08-15 17:48       ` Philippe Mathieu-Daudé
2017-08-15 16:32     ` Richard Henderson
2017-08-15 17:49       ` Philippe Mathieu-Daudé
2017-08-15 17:16 ` [Qemu-devel] [PATCH v2 for-2.10 0/3] Fixup logic for exclusive pair Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170815145714.17635-1-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alistair.francis@xilinx.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).