From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1di2W6-000796-7u for qemu-devel@nongnu.org; Wed, 16 Aug 2017 13:54:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1di2W2-00012a-AZ for qemu-devel@nongnu.org; Wed, 16 Aug 2017 13:54:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33222) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1di2W2-00012G-1C for qemu-devel@nongnu.org; Wed, 16 Aug 2017 13:54:02 -0400 Date: Wed, 16 Aug 2017 18:53:52 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170816175352.GE2494@work-vm> References: <1502881586-25044-1-git-send-email-vadim.galitsyn@profitbricks.com> <1502881586-25044-3-git-send-email-vadim.galitsyn@profitbricks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502881586-25044-3-git-send-email-vadim.galitsyn@profitbricks.com> Subject: Re: [Qemu-devel] [PATCH v6 3/3] hmp: introduce 'info memory_size_summary' command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vadim Galitsyn Cc: Eduardo Habkost , David Hildenbrand , Markus Armbruster , Igor Mammedov , Eric Blake , qemu-devel@nongnu.org, Vasilis Liaskovitis , Mohammed Gamal , Eduardo Otubo * Vadim Galitsyn (vadim.galitsyn@profitbricks.com) wrote: > This command is an equivalent of QMP command query-memory-size-summary. > It provides the following memory information in bytes: > > * base-memory - size of "base" memory specified with command line option -m. > > * plugged-memory - amount of memory that was hot-plugged. > If target does not have CONFIG_MEM_HOTPLUG enabled, no > value is reported. > > Signed-off-by: Vasilis Liaskovitis > Signed-off-by: Mohammed Gamal > Signed-off-by: Eduardo Otubo > Signed-off-by: Vadim Galitsyn > Reviewed-by: Eugene Crosser > Cc: Dr. David Alan Gilbert > Cc: Markus Armbruster > Cc: Igor Mammedov > Cc: Eric Blake > Cc: qemu-devel@nongnu.org > --- > hmp-commands-info.hx | 16 ++++++++++++++++ > hmp.c | 16 ++++++++++++++++ > hmp.h | 1 + > 3 files changed, 33 insertions(+) > > diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx > index d9df238..04c9db8 100644 > --- a/hmp-commands-info.hx > +++ b/hmp-commands-info.hx > @@ -850,6 +850,22 @@ ETEXI > }, > > STEXI > +@item info memory_size_summary > +@findex memory_size_summary > +Display the amount of initially allocated and hot-plugged (if > +enabled) memory in bytes. > +ETEXI > + > + { > + .name = "memory_size_summary", > + .args_type = "", > + .params = "", > + .help = "show the amount of initially allocated and " > + "hot-plugged (if enabled) memory in bytes.", > + .cmd = hmp_info_memory_size_summary, > + }, > + > +STEXI > @end table > ETEXI > > diff --git a/hmp.c b/hmp.c > index fd80dce..3615e71 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -2868,3 +2868,19 @@ void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict) > hmp_handle_error(mon, &err); > qapi_free_GuidInfo(info); > } > + > +void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict) > +{ > + MemoryInfo *info = qmp_query_memory_size_summary(&error_abort); That should use hmp_handle_error rather than error_abort; see hmp_info_vm_generation_id as an example. Other than that, I'm happy from the HMP side. Dave > + if (info) { > + monitor_printf(mon, "base memory: %" PRIu64 "\n", > + info->base_memory); > + > + if (info->has_plugged_memory) { > + monitor_printf(mon, "plugged memory: %" PRIu64 "\n", > + info->plugged_memory); > + } > + > + qapi_free_MemoryInfo(info); > + } > +} > diff --git a/hmp.h b/hmp.h > index 1ff4552..3605003 100644 > --- a/hmp.h > +++ b/hmp.h > @@ -145,5 +145,6 @@ void hmp_info_dump(Monitor *mon, const QDict *qdict); > void hmp_info_ramblock(Monitor *mon, const QDict *qdict); > void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict); > void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict); > +void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict); > > #endif > -- > 2.1.4 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK