From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: rth@twiddle.net, Aurelien Jarno <aurelien@aurel32.net>,
thuth@redhat.com, cohuck@redhat.com, david@redhat.com,
borntraeger@de.ibm.com
Subject: [Qemu-devel] [PATCH v1 for-2.11 00/10] target/s390x: cleanup cpu.h
Date: Thu, 17 Aug 2017 11:22:15 +0200 [thread overview]
Message-ID: <20170817092225.4264-1-david@redhat.com> (raw)
cpu.h is accessed outside of target/s390x. It should only contain
what is expected to be accessed outside of this folder. Therefore, create
internal.h and move a lot to that file. In addition, introduce
kvm-stub.c and kvm_390x.h for kvm specific functions.
Let's see what compilers think about this version.
RFC -> v1:
- (hopefully) fixed a compile error
- move some functions from cpu.h to the only c file they are used in
- move kvm function and stubs to kvm_s390x.h and kvm-stub.c
- smaller requested style fixes
David Hildenbrand (10):
target/s390x: move cc_name() to cc_helper.c
target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c
target/s390x: move psw_key_valid() to mem_helper.c
target/s390x: move s390_do_cpu_reset() to diag.c
target/s390x: move get_per_in_range() to misc_helper.c
target/s390x: introduce internal.h
target/s390x: move a couple of functions to cpu.c
s390x: avoid calling kvm_ functions outside of target/s390x/
s390x/kvm: move KVM declarations and stubs to separate files
target/s390x: cleanup cpu.h
hw/s390x/s390-virtio-ccw.c | 4 +-
target/s390x/Makefile.objs | 1 +
target/s390x/arch_dump.c | 1 +
target/s390x/cc_helper.c | 49 +++
target/s390x/cpu.c | 87 ++++++
target/s390x/cpu.h | 761 +++++----------------------------------------
target/s390x/cpu_models.c | 1 +
target/s390x/diag.c | 8 +
target/s390x/excp_helper.c | 15 +
target/s390x/fpu_helper.c | 1 +
target/s390x/gdbstub.c | 1 +
target/s390x/helper.c | 1 +
target/s390x/int_helper.c | 1 +
target/s390x/internal.h | 391 +++++++++++++++++++++++
target/s390x/interrupt.c | 1 +
target/s390x/ioinst.c | 1 +
target/s390x/kvm-stub.c | 111 +++++++
target/s390x/kvm.c | 1 +
target/s390x/kvm_s390x.h | 51 +++
target/s390x/machine.c | 1 +
target/s390x/mem_helper.c | 12 +
target/s390x/misc_helper.c | 12 +
target/s390x/mmu_helper.c | 1 +
target/s390x/translate.c | 1 +
24 files changed, 820 insertions(+), 694 deletions(-)
create mode 100644 target/s390x/internal.h
create mode 100644 target/s390x/kvm-stub.c
create mode 100644 target/s390x/kvm_s390x.h
--
2.9.4
next reply other threads:[~2017-08-17 9:22 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 9:22 David Hildenbrand [this message]
2017-08-17 9:22 ` [Qemu-devel] [PATCH v1 for-2.11 01/10] target/s390x: move cc_name() to cc_helper.c David Hildenbrand
2017-08-17 11:01 ` Thomas Huth
2017-08-18 3:47 ` Richard Henderson
2017-08-18 9:59 ` David Hildenbrand
2017-08-18 10:04 ` Thomas Huth
2017-08-18 10:50 ` Cornelia Huck
2017-08-17 9:22 ` [Qemu-devel] [PATCH v1 for-2.11 02/10] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c David Hildenbrand
2017-08-17 11:03 ` Thomas Huth
2017-08-18 3:52 ` Richard Henderson
2017-08-17 9:22 ` [Qemu-devel] [PATCH v1 for-2.11 03/10] target/s390x: move psw_key_valid() to mem_helper.c David Hildenbrand
2017-08-17 11:04 ` Thomas Huth
2017-08-18 3:54 ` Richard Henderson
2017-08-17 9:22 ` [Qemu-devel] [PATCH v1 for-2.11 04/10] target/s390x: move s390_do_cpu_reset() to diag.c David Hildenbrand
2017-08-17 11:05 ` Thomas Huth
2017-08-18 3:55 ` Richard Henderson
2017-08-17 9:22 ` [Qemu-devel] [PATCH v1 for-2.11 05/10] target/s390x: move get_per_in_range() to misc_helper.c David Hildenbrand
2017-08-17 11:09 ` Thomas Huth
2017-08-18 3:56 ` Richard Henderson
2017-08-17 9:22 ` [Qemu-devel] [PATCH v1 for-2.11 06/10] target/s390x: introduce internal.h David Hildenbrand
2017-08-17 11:59 ` Thomas Huth
2017-08-17 9:22 ` [Qemu-devel] [PATCH v1 for-2.11 07/10] target/s390x: move a couple of functions to cpu.c David Hildenbrand
2017-08-17 9:22 ` [Qemu-devel] [PATCH v1 for-2.11 08/10] s390x: avoid calling kvm_ functions outside of target/s390x/ David Hildenbrand
2017-08-17 9:22 ` [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files David Hildenbrand
[not found] ` <f2b025c6-bfd9-2b01-497c-d08f262bd0d5@amsat.org>
2017-08-17 12:21 ` David Hildenbrand
2017-08-17 12:35 ` Thomas Huth
2017-08-17 12:45 ` Philippe Mathieu-Daudé
2017-08-17 12:48 ` Cornelia Huck
2017-08-17 12:53 ` David Hildenbrand
2017-08-17 13:04 ` Cornelia Huck
2017-08-17 12:55 ` David Hildenbrand
2017-08-17 13:06 ` Thomas Huth
2017-08-17 13:07 ` Cornelia Huck
2017-08-17 13:10 ` David Hildenbrand
2017-08-17 13:14 ` David Hildenbrand
2017-08-17 13:30 ` Philippe Mathieu-Daudé
2017-08-18 4:05 ` Richard Henderson
2017-08-17 9:22 ` [Qemu-devel] [PATCH v1 for-2.11 10/10] target/s390x: cleanup cpu.h David Hildenbrand
2017-08-17 12:41 ` Thomas Huth
2017-08-17 13:09 ` Cornelia Huck
2017-08-17 11:42 ` [Qemu-devel] [PATCH v1 for-2.11 00/10] " Philippe Mathieu-Daudé
2017-08-17 13:11 ` Cornelia Huck
2017-08-17 13:12 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817092225.4264-1-david@redhat.com \
--to=david@redhat.com \
--cc=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).