From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
David Hildenbrand <david@redhat.com>,
Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>,
Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,
Eric Farman <farman@linux.vnet.ibm.com>,
Fan Zhang <zhangfan@linux.vnet.ibm.com>,
Farhan Ali <alifm@linux.vnet.ibm.com>,
Fei Li <sherrylf@linux.vnet.ibm.com>,
Halil Pasic <pasic@linux.vnet.ibm.com>,
Janosch Frank <frankja@linux.vnet.ibm.com>,
Jason J Herne <jjherne@linux.vnet.ibm.com>,
Jing Liu <liujbjl@linux.vnet.ibm.com>,
Pierre Morel <pmorel@linux.vnet.ibm.com>,
QingFeng Hao <haoqf@linux.vnet.ibm.com>,
Xiao Feng Ren <renxiaof@linux.vnet.ibm.com>,
Yang Chen <bjcyang@linux.vnet.ibm.com>,
Yi Min Zhao <zyimin@linux.vnet.ibm.com>,
Marc Mari <markmb@redhat.com>, Cleber Rosa <crosa@redhat.com>,
Michael S Tsirkin <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/6] tests: Enable the drive_del test also on s390x
Date: Thu, 17 Aug 2017 10:53:05 +0200 [thread overview]
Message-ID: <20170817105305.3d845d40.cohuck@redhat.com> (raw)
In-Reply-To: <1502951113-4246-4-git-send-email-thuth@redhat.com>
On Thu, 17 Aug 2017 08:25:10 +0200
Thomas Huth <thuth@redhat.com> wrote:
> By using the "virtio-xxx" device name aliases instead of the
> "virtio-xxx-pci" names, we can use this test on s390x, too,
> to check that adding and deleting also works fine with the
> virtio-ccw bus.
I don't think we should leak the aliasing stuff into tests, but rather
specify the transport on a per-architecture basis explicitly. (We might
want to test virtio-pci on s390x in the future as well -- in addition
to virtio-ccw, not replacing it.)
Also, the same question as for the previous patch: Is this supposed to
test virtio explicitly, or do we just want a reasonable device?
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/Makefile.include | 1 +
> tests/drive_del-test.c | 13 +++++++------
> 2 files changed, 8 insertions(+), 6 deletions(-)
next prev parent reply other threads:[~2017-08-17 8:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 6:25 [Qemu-devel] [PATCH for-2.11 0/6] Enable more qtests for s390x Thomas Huth
2017-08-17 6:25 ` [Qemu-devel] [PATCH 1/6] tests: Run filter-redirector and -mirror test only on POSIX systems Thomas Huth
2017-08-17 8:25 ` Cornelia Huck
2017-08-17 9:41 ` David Hildenbrand
2017-08-17 10:09 ` Zhang Chen
2017-08-30 19:35 ` Cleber Rosa
2017-08-17 6:25 ` [Qemu-devel] [PATCH 2/6] tests: Add network filter tests to the check-qtest-s390x list Thomas Huth
2017-08-17 8:41 ` Cornelia Huck
2017-08-17 14:02 ` Thomas Huth
2017-08-18 1:49 ` Zhang Chen
2017-08-18 7:54 ` Cornelia Huck
2017-08-18 8:47 ` Thomas Huth
2017-08-30 20:05 ` Cleber Rosa
2017-08-30 20:03 ` Cleber Rosa
2017-08-17 6:25 ` [Qemu-devel] [PATCH 3/6] tests: Enable the drive_del test also on s390x Thomas Huth
2017-08-17 8:53 ` Cornelia Huck [this message]
2017-08-17 9:46 ` David Hildenbrand
2017-08-17 13:54 ` Thomas Huth
2017-08-17 14:01 ` Cornelia Huck
2017-08-30 21:41 ` Cleber Rosa
2017-09-04 13:49 ` Cornelia Huck
2017-08-17 6:25 ` [Qemu-devel] [PATCH 4/6] tests: Introduce generic device hot-plug/hot-unplug functions Thomas Huth
2017-08-17 9:00 ` Cornelia Huck
2017-08-17 9:53 ` David Hildenbrand
2017-08-17 10:57 ` Thomas Huth
2017-08-17 11:16 ` David Hildenbrand
2017-08-17 6:25 ` [Qemu-devel] [PATCH 5/6] tests: Add qvirtio_(un)plug_device_test wrapper functions Thomas Huth
2017-08-17 9:04 ` Cornelia Huck
2017-08-17 6:25 ` [Qemu-devel] [PATCH 6/6] tests: Enable the simple virtio tests on s390x, too Thomas Huth
2017-08-17 9:07 ` Cornelia Huck
2017-08-17 9:11 ` [Qemu-devel] [PATCH for-2.11 0/6] Enable more qtests for s390x Cornelia Huck
2017-08-18 13:40 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817105305.3d845d40.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alifm@linux.vnet.ibm.com \
--cc=bjcyang@linux.vnet.ibm.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=crosa@redhat.com \
--cc=david@redhat.com \
--cc=farman@linux.vnet.ibm.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=haoqf@linux.vnet.ibm.com \
--cc=imbrenda@linux.vnet.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=liujbjl@linux.vnet.ibm.com \
--cc=markmb@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=renxiaof@linux.vnet.ibm.com \
--cc=sherrylf@linux.vnet.ibm.com \
--cc=thuth@redhat.com \
--cc=zhangfan@linux.vnet.ibm.com \
--cc=zyimin@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).