* [Qemu-devel] [PATCH] hw/s390x/ipl: The s390-ipl device is not hot-pluggable
@ 2017-08-16 5:30 Thomas Huth
2017-08-16 12:33 ` Cornelia Huck
2017-08-17 9:05 ` David Hildenbrand
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Huth @ 2017-08-16 5:30 UTC (permalink / raw)
To: Cornelia Huck, qemu-devel; +Cc: Christian Borntraeger
The s390-ipl device can not be created by the user, since it is meant only
to be instantiated once internally to load the ROMs and kernel. If the user
tries to do a "device_add s390-ipl" via the monitor later, QEMU aborts with
a "ROM images must be loaded at startup" error message.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/s390x/ipl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
index cc36003..0d06fc1 100644
--- a/hw/s390x/ipl.c
+++ b/hw/s390x/ipl.c
@@ -442,6 +442,8 @@ static void s390_ipl_class_init(ObjectClass *klass, void *data)
dc->reset = s390_ipl_reset;
dc->vmsd = &vmstate_ipl;
set_bit(DEVICE_CATEGORY_MISC, dc->categories);
+ /* Reason: Loads the ROMs and thus can only be used one time - internally */
+ dc->user_creatable = false;
}
static const TypeInfo s390_ipl_info = {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hw/s390x/ipl: The s390-ipl device is not hot-pluggable
2017-08-16 5:30 [Qemu-devel] [PATCH] hw/s390x/ipl: The s390-ipl device is not hot-pluggable Thomas Huth
@ 2017-08-16 12:33 ` Cornelia Huck
2017-08-17 9:05 ` David Hildenbrand
1 sibling, 0 replies; 4+ messages in thread
From: Cornelia Huck @ 2017-08-16 12:33 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, Christian Borntraeger
On Wed, 16 Aug 2017 07:30:58 +0200
Thomas Huth <thuth@redhat.com> wrote:
> The s390-ipl device can not be created by the user, since it is meant only
> to be instantiated once internally to load the ROMs and kernel. If the user
> tries to do a "device_add s390-ipl" via the monitor later, QEMU aborts with
> a "ROM images must be loaded at startup" error message.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/s390x/ipl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index cc36003..0d06fc1 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -442,6 +442,8 @@ static void s390_ipl_class_init(ObjectClass *klass, void *data)
> dc->reset = s390_ipl_reset;
> dc->vmsd = &vmstate_ipl;
> set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> + /* Reason: Loads the ROMs and thus can only be used one time - internally */
> + dc->user_creatable = false;
> }
>
> static const TypeInfo s390_ipl_info = {
Thanks, applied.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hw/s390x/ipl: The s390-ipl device is not hot-pluggable
2017-08-16 5:30 [Qemu-devel] [PATCH] hw/s390x/ipl: The s390-ipl device is not hot-pluggable Thomas Huth
2017-08-16 12:33 ` Cornelia Huck
@ 2017-08-17 9:05 ` David Hildenbrand
2017-08-17 9:16 ` Cornelia Huck
1 sibling, 1 reply; 4+ messages in thread
From: David Hildenbrand @ 2017-08-17 9:05 UTC (permalink / raw)
To: Thomas Huth, Cornelia Huck, qemu-devel; +Cc: Christian Borntraeger
On 16.08.2017 07:30, Thomas Huth wrote:
> The s390-ipl device can not be created by the user, since it is meant only
> to be instantiated once internally to load the ROMs and kernel. If the user
> tries to do a "device_add s390-ipl" via the monitor later, QEMU aborts with
> a "ROM images must be loaded at startup" error message.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/s390x/ipl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index cc36003..0d06fc1 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -442,6 +442,8 @@ static void s390_ipl_class_init(ObjectClass *klass, void *data)
> dc->reset = s390_ipl_reset;
> dc->vmsd = &vmstate_ipl;
> set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> + /* Reason: Loads the ROMs and thus can only be used one time - internally */
> + dc->user_creatable = false;
> }
>
> static const TypeInfo s390_ipl_info = {
>
Late but still
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hw/s390x/ipl: The s390-ipl device is not hot-pluggable
2017-08-17 9:05 ` David Hildenbrand
@ 2017-08-17 9:16 ` Cornelia Huck
0 siblings, 0 replies; 4+ messages in thread
From: Cornelia Huck @ 2017-08-17 9:16 UTC (permalink / raw)
To: David Hildenbrand; +Cc: Thomas Huth, qemu-devel, Christian Borntraeger
On Thu, 17 Aug 2017 11:05:35 +0200
David Hildenbrand <david@redhat.com> wrote:
> On 16.08.2017 07:30, Thomas Huth wrote:
> > The s390-ipl device can not be created by the user, since it is meant only
> > to be instantiated once internally to load the ROMs and kernel. If the user
> > tries to do a "device_add s390-ipl" via the monitor later, QEMU aborts with
> > a "ROM images must be loaded at startup" error message.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> > hw/s390x/ipl.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> > index cc36003..0d06fc1 100644
> > --- a/hw/s390x/ipl.c
> > +++ b/hw/s390x/ipl.c
> > @@ -442,6 +442,8 @@ static void s390_ipl_class_init(ObjectClass *klass, void *data)
> > dc->reset = s390_ipl_reset;
> > dc->vmsd = &vmstate_ipl;
> > set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> > + /* Reason: Loads the ROMs and thus can only be used one time - internally */
> > + dc->user_creatable = false;
> > }
> >
> > static const TypeInfo s390_ipl_info = {
> >
>
> Late but still
>
> Reviewed-by: David Hildenbrand <david@redhat.com>
>
Not too late for me to add the tag :)
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-17 9:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-16 5:30 [Qemu-devel] [PATCH] hw/s390x/ipl: The s390-ipl device is not hot-pluggable Thomas Huth
2017-08-16 12:33 ` Cornelia Huck
2017-08-17 9:05 ` David Hildenbrand
2017-08-17 9:16 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).