qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Hervé Poussineau" <hpoussin@reactos.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Yongbok Kim" <yongbok.kim@imgtec.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"James Hogan" <james.hogan@imgtec.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 6/8] !fixup mips: now than MIPSCPU is QOMified, mark it abstract
Date: Thu, 17 Aug 2017 17:17:32 +0200	[thread overview]
Message-ID: <20170817171732.1413fcaf@nial.brq.redhat.com> (raw)
In-Reply-To: <20170817043102.6322-7-f4bug@amsat.org>

On Thu, 17 Aug 2017 01:31:00 -0300
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/mips/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

looks good, just squash it into previous patch

> 
> diff --git a/target/mips/cpu.c b/target/mips/cpu.c
> index f99cfbde7e..84b6f8bf68 100644
> --- a/target/mips/cpu.c
> +++ b/target/mips/cpu.c
> @@ -219,7 +219,7 @@ static const TypeInfo mips_cpu_type_info = {
>      .parent = TYPE_CPU,
>      .instance_size = sizeof(MIPSCPU),
>      .instance_init = mips_cpu_initfn,
> -    .abstract = false,
> +    .abstract = true,
>      .class_size = sizeof(MIPSCPUClass),
>      .class_init = mips_cpu_class_init,
>  };

  reply	other threads:[~2017-08-17 15:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17  4:30 [Qemu-devel] [PATCH 0/8] QOMify MIPS cpu Philippe Mathieu-Daudé
2017-08-17  4:30 ` [Qemu-devel] [PATCH 1/8] mips: move hw/mips/cputimer.c to target/mips/ Philippe Mathieu-Daudé
2017-08-17  4:30 ` [Qemu-devel] [PATCH 2/8] mips: introduce internal.h and cleanup cpu.h Philippe Mathieu-Daudé
2017-08-17 14:38   ` Igor Mammedov
2017-08-17 15:06     ` Philippe Mathieu-Daudé
2017-08-18 20:03       ` Philippe Mathieu-Daudé
2017-08-21  8:57         ` Igor Mammedov
2017-08-17  4:30 ` [Qemu-devel] [PATCH 3/8] mips: split cpu_mips_realize_env() out of cpu_mips_init() Philippe Mathieu-Daudé
2017-08-17  4:30 ` [Qemu-devel] [PATCH 4/8] mips: call cpu_mips_realize_env() from mips_cpu_realizefn() Philippe Mathieu-Daudé
2017-08-17  4:30 ` [Qemu-devel] [PATCH 5/8] mips: MIPSCPU model subclasses Philippe Mathieu-Daudé
2017-08-17  4:31 ` [Qemu-devel] [RFC PATCH 6/8] !fixup mips: now than MIPSCPU is QOMified, mark it abstract Philippe Mathieu-Daudé
2017-08-17 15:17   ` Igor Mammedov [this message]
2017-08-17  4:31 ` [Qemu-devel] [PATCH 7/8] mips: replace cpu_mips_init() with cpu_generic_init() Philippe Mathieu-Daudé
2017-08-17  4:31 ` [Qemu-devel] [PATCH 8/8] mips: update mips_cpu_list() to use object_class_get_list() Philippe Mathieu-Daudé
2017-08-17  4:54 ` [Qemu-devel] [PATCH 0/8] QOMify MIPS cpu no-reply
2017-08-17 16:34   ` Philippe Mathieu-Daudé
2017-08-17 15:22 ` Igor Mammedov
2017-08-18 20:08   ` Philippe Mathieu-Daudé
2017-08-21  9:02     ` Igor Mammedov
2017-08-30 13:50     ` Igor Mammedov
2017-08-30 14:41       ` Philippe Mathieu-Daudé
2017-08-30 18:19         ` James Hogan
2017-08-30 19:52           ` Philippe Mathieu-Daudé
2017-08-30 20:53             ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170817171732.1413fcaf@nial.brq.redhat.com \
    --to=imammedo@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=hpoussin@reactos.org \
    --cc=james.hogan@imgtec.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=yongbok.kim@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).