From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: rth@twiddle.net, "Aurelien Jarno" <aurelien@aurel32.net>,
thuth@redhat.com, cohuck@redhat.com, david@redhat.com,
borntraeger@de.ibm.com,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PATCH v3 for-2.11 02/18] s390x/kvm: drop KVMState parameter from kvm_s390_set_mem_limit()
Date: Fri, 18 Aug 2017 13:43:37 +0200 [thread overview]
Message-ID: <20170818114353.13455-3-david@redhat.com> (raw)
In-Reply-To: <20170818114353.13455-1-david@redhat.com>
Not needed at that point. Also drop it from kvm_s390_query_mem_limit()
we call in kvm_s390_set_mem_limit().
Signed-off-by: David Hildenbrand <david@redhat.com>
---
target/s390x/cpu.h | 7 +++----
target/s390x/kvm.c | 12 ++++++------
2 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index 44b1a7a..798e299 100644
--- a/target/s390x/cpu.h
+++ b/target/s390x/cpu.h
@@ -1169,7 +1169,7 @@ int kvm_s390_cmma_active(void);
void kvm_s390_cmma_reset(void);
int kvm_s390_set_cpu_state(S390CPU *cpu, uint8_t cpu_state);
void kvm_s390_reset_vcpu(S390CPU *cpu);
-int kvm_s390_set_mem_limit(KVMState *s, uint64_t new_limit, uint64_t *hw_limit);
+int kvm_s390_set_mem_limit(uint64_t new_limit, uint64_t *hw_limit);
void kvm_s390_vcpu_interrupt_pre_save(S390CPU *cpu);
int kvm_s390_vcpu_interrupt_post_load(S390CPU *cpu);
int kvm_s390_get_ri(void);
@@ -1215,8 +1215,7 @@ static inline int kvm_s390_set_cpu_state(S390CPU *cpu, uint8_t cpu_state)
static inline void kvm_s390_reset_vcpu(S390CPU *cpu)
{
}
-static inline int kvm_s390_set_mem_limit(KVMState *s, uint64_t new_limit,
- uint64_t *hw_limit)
+static inline int kvm_s390_set_mem_limit(uint64_t new_limit, uint64_t *hw_limit)
{
return 0;
}
@@ -1243,7 +1242,7 @@ static inline void kvm_s390_crypto_reset(void)
static inline int s390_set_memory_limit(uint64_t new_limit, uint64_t *hw_limit)
{
if (kvm_enabled()) {
- return kvm_s390_set_mem_limit(kvm_state, new_limit, hw_limit);
+ return kvm_s390_set_mem_limit(new_limit, hw_limit);
}
return 0;
}
diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
index d0bb9e9..0e324ae 100644
--- a/target/s390x/kvm.c
+++ b/target/s390x/kvm.c
@@ -145,7 +145,7 @@ static int active_cmma;
static void *legacy_s390_alloc(size_t size, uint64_t *align);
-static int kvm_s390_query_mem_limit(KVMState *s, uint64_t *memory_limit)
+static int kvm_s390_query_mem_limit(uint64_t *memory_limit)
{
struct kvm_device_attr attr = {
.group = KVM_S390_VM_MEM_CTRL,
@@ -153,10 +153,10 @@ static int kvm_s390_query_mem_limit(KVMState *s, uint64_t *memory_limit)
.addr = (uint64_t) memory_limit,
};
- return kvm_vm_ioctl(s, KVM_GET_DEVICE_ATTR, &attr);
+ return kvm_vm_ioctl(kvm_state, KVM_GET_DEVICE_ATTR, &attr);
}
-int kvm_s390_set_mem_limit(KVMState *s, uint64_t new_limit, uint64_t *hw_limit)
+int kvm_s390_set_mem_limit(uint64_t new_limit, uint64_t *hw_limit)
{
int rc;
@@ -166,18 +166,18 @@ int kvm_s390_set_mem_limit(KVMState *s, uint64_t new_limit, uint64_t *hw_limit)
.addr = (uint64_t) &new_limit,
};
- if (!kvm_vm_check_mem_attr(s, KVM_S390_VM_MEM_LIMIT_SIZE)) {
+ if (!kvm_vm_check_mem_attr(kvm_state, KVM_S390_VM_MEM_LIMIT_SIZE)) {
return 0;
}
- rc = kvm_s390_query_mem_limit(s, hw_limit);
+ rc = kvm_s390_query_mem_limit(hw_limit);
if (rc) {
return rc;
} else if (*hw_limit < new_limit) {
return -E2BIG;
}
- return kvm_vm_ioctl(s, KVM_SET_DEVICE_ATTR, &attr);
+ return kvm_vm_ioctl(kvm_state, KVM_SET_DEVICE_ATTR, &attr);
}
int kvm_s390_cmma_active(void)
--
2.9.4
next prev parent reply other threads:[~2017-08-18 11:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 11:43 [Qemu-devel] [PATCH v3 for-2.11 00/18] target/s390x: cleanup cpu.h David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 01/18] s390x/kvm: drop KVMState parameter from s390_get_memslot_count() David Hildenbrand
2017-08-18 15:36 ` Thomas Huth
2017-08-18 11:43 ` David Hildenbrand [this message]
2017-08-18 15:39 ` [Qemu-devel] [PATCH v3 for-2.11 02/18] s390x/kvm: drop KVMState parameter from kvm_s390_set_mem_limit() Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 03/18] target/s390x: simplify ri_allowed() David Hildenbrand
2017-08-18 15:52 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 04/18] target/s390x: simplify gs_allowed() David Hildenbrand
2017-08-18 15:59 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 05/18] target/s390x: no need to pass kvm_state to savevm_gtod handlers David Hildenbrand
2017-08-18 15:41 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 06/18] s390x/cpumodel: factor out determination of default model name David Hildenbrand
2017-08-18 16:04 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of sysemu/kvm.h from some files David Hildenbrand
2017-08-18 16:08 ` Thomas Huth
2017-08-18 17:28 ` David Hildenbrand
2017-08-21 9:52 ` Cornelia Huck
2017-08-21 10:50 ` David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h David Hildenbrand
2017-08-18 16:11 ` Thomas Huth
2017-08-18 17:28 ` David Hildenbrand
2017-08-24 12:08 ` Cornelia Huck
2017-08-21 10:08 ` Cornelia Huck
2017-08-21 11:05 ` David Hildenbrand
2017-08-21 11:14 ` Cornelia Huck
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 09/18] target/s390x: move cc_name() to helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 10/18] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 11/18] target/s390x: move psw_key_valid() to mem_helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 12/18] target/s390x: move s390_do_cpu_reset() to diag.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 13/18] target/s390x: move get_per_in_range() to misc_helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 14/18] target/s390x: introduce internal.h David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 15/18] target/s390x: move a couple of functions to cpu.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 16/18] s390x: avoid calling kvm_ functions outside of target/s390x/ David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 17/18] s390x/kvm: move KVM declarations and stubs to separate files David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 18/18] target/s390x: cleanup cpu.h David Hildenbrand
2017-08-18 11:45 ` [Qemu-devel] [PATCH v3 for-2.11 00/18] " David Hildenbrand
2017-08-24 12:30 ` Cornelia Huck
2017-08-25 9:26 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818114353.13455-3-david@redhat.com \
--to=david@redhat.com \
--cc=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).