From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: rth@twiddle.net, "Aurelien Jarno" <aurelien@aurel32.net>,
thuth@redhat.com, cohuck@redhat.com, david@redhat.com,
borntraeger@de.ibm.com,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PATCH v3 for-2.11 04/18] target/s390x: simplify gs_allowed()
Date: Fri, 18 Aug 2017 13:43:39 +0200 [thread overview]
Message-ID: <20170818114353.13455-5-david@redhat.com> (raw)
In-Reply-To: <20170818114353.13455-1-david@redhat.com>
No need for kvm_enabled() as this function is only called from KVM and
there is no reason why it shouldn't be allowed for tcg. It is simply not
available under tcg.
Also, there is no need to check for the machine type anymore. Just like
ri_enabled(), we can directly use the stored flag, which results in
"true" for the "none" machine.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/s390x/s390-virtio-ccw.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 3a674f5..3e9b455 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -288,18 +288,8 @@ bool cpu_model_allowed(void)
bool gs_allowed(void)
{
- if (kvm_enabled()) {
- MachineClass *mc = MACHINE_GET_CLASS(qdev_get_machine());
- if (object_class_dynamic_cast(OBJECT_CLASS(mc),
- TYPE_S390_CCW_MACHINE)) {
- S390CcwMachineClass *s390mc = S390_MACHINE_CLASS(mc);
-
- return s390mc->gs_allowed;
- }
- /* Make sure the "none" machine can have gs */
- return true;
- }
- return false;
+ /* for "none" machine this results in true */
+ return get_machine_class()->gs_allowed;
}
static char *machine_get_loadparm(Object *obj, Error **errp)
--
2.9.4
next prev parent reply other threads:[~2017-08-18 11:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 11:43 [Qemu-devel] [PATCH v3 for-2.11 00/18] target/s390x: cleanup cpu.h David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 01/18] s390x/kvm: drop KVMState parameter from s390_get_memslot_count() David Hildenbrand
2017-08-18 15:36 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 02/18] s390x/kvm: drop KVMState parameter from kvm_s390_set_mem_limit() David Hildenbrand
2017-08-18 15:39 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 03/18] target/s390x: simplify ri_allowed() David Hildenbrand
2017-08-18 15:52 ` Thomas Huth
2017-08-18 11:43 ` David Hildenbrand [this message]
2017-08-18 15:59 ` [Qemu-devel] [PATCH v3 for-2.11 04/18] target/s390x: simplify gs_allowed() Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 05/18] target/s390x: no need to pass kvm_state to savevm_gtod handlers David Hildenbrand
2017-08-18 15:41 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 06/18] s390x/cpumodel: factor out determination of default model name David Hildenbrand
2017-08-18 16:04 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of sysemu/kvm.h from some files David Hildenbrand
2017-08-18 16:08 ` Thomas Huth
2017-08-18 17:28 ` David Hildenbrand
2017-08-21 9:52 ` Cornelia Huck
2017-08-21 10:50 ` David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h David Hildenbrand
2017-08-18 16:11 ` Thomas Huth
2017-08-18 17:28 ` David Hildenbrand
2017-08-24 12:08 ` Cornelia Huck
2017-08-21 10:08 ` Cornelia Huck
2017-08-21 11:05 ` David Hildenbrand
2017-08-21 11:14 ` Cornelia Huck
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 09/18] target/s390x: move cc_name() to helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 10/18] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 11/18] target/s390x: move psw_key_valid() to mem_helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 12/18] target/s390x: move s390_do_cpu_reset() to diag.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 13/18] target/s390x: move get_per_in_range() to misc_helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 14/18] target/s390x: introduce internal.h David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 15/18] target/s390x: move a couple of functions to cpu.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 16/18] s390x: avoid calling kvm_ functions outside of target/s390x/ David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 17/18] s390x/kvm: move KVM declarations and stubs to separate files David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 18/18] target/s390x: cleanup cpu.h David Hildenbrand
2017-08-18 11:45 ` [Qemu-devel] [PATCH v3 for-2.11 00/18] " David Hildenbrand
2017-08-24 12:30 ` Cornelia Huck
2017-08-25 9:26 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818114353.13455-5-david@redhat.com \
--to=david@redhat.com \
--cc=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).