From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: rth@twiddle.net, "Aurelien Jarno" <aurelien@aurel32.net>,
thuth@redhat.com, cohuck@redhat.com, david@redhat.com,
borntraeger@de.ibm.com,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PATCH v3 for-2.11 06/18] s390x/cpumodel: factor out determination of default model name
Date: Fri, 18 Aug 2017 13:43:41 +0200 [thread overview]
Message-ID: <20170818114353.13455-7-david@redhat.com> (raw)
In-Reply-To: <20170818114353.13455-1-david@redhat.com>
Now we can drop inclusion of "sysemu/kvm.h" from "s390-virtio.c".
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/s390x/s390-virtio.c | 7 +------
target/s390x/cpu.h | 1 +
target/s390x/cpu_models.c | 8 ++++++++
3 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c
index afa4148..da3f49e 100644
--- a/hw/s390x/s390-virtio.c
+++ b/hw/s390x/s390-virtio.c
@@ -33,7 +33,6 @@
#include "hw/boards.h"
#include "hw/loader.h"
#include "hw/virtio/virtio.h"
-#include "sysemu/kvm.h"
#include "exec/address-spaces.h"
#include "sysemu/qtest.h"
@@ -93,11 +92,7 @@ void s390_init_cpus(MachineState *machine)
gchar *name;
if (machine->cpu_model == NULL) {
- if (kvm_enabled()) {
- machine->cpu_model = "host";
- } else {
- machine->cpu_model = "qemu";
- }
+ machine->cpu_model = s390_default_cpu_model_name();
}
cpu_states = g_new0(S390CPU *, max_cpus);
diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index 798e299..3ce7ffc 100644
--- a/target/s390x/cpu.h
+++ b/target/s390x/cpu.h
@@ -647,6 +647,7 @@ void s390_cpu_model_register_props(Object *obj);
void s390_cpu_model_class_register_props(ObjectClass *oc);
void s390_realize_cpu_model(CPUState *cs, Error **errp);
ObjectClass *s390_cpu_class_by_name(const char *name);
+const char *s390_default_cpu_model_name(void);
#define EXCP_EXT 1 /* external interrupt */
#define EXCP_SVC 2 /* supervisor call (syscall) */
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index fa1338f..915f067 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -1200,6 +1200,14 @@ ObjectClass *s390_cpu_class_by_name(const char *name)
return oc;
}
+const char *s390_default_cpu_model_name(void)
+{
+ if (kvm_enabled()) {
+ return "host";
+ }
+ return "qemu";
+}
+
static const TypeInfo qemu_s390_cpu_type_info = {
.name = S390_CPU_TYPE_NAME("qemu"),
.parent = TYPE_S390_CPU,
--
2.9.4
next prev parent reply other threads:[~2017-08-18 11:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 11:43 [Qemu-devel] [PATCH v3 for-2.11 00/18] target/s390x: cleanup cpu.h David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 01/18] s390x/kvm: drop KVMState parameter from s390_get_memslot_count() David Hildenbrand
2017-08-18 15:36 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 02/18] s390x/kvm: drop KVMState parameter from kvm_s390_set_mem_limit() David Hildenbrand
2017-08-18 15:39 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 03/18] target/s390x: simplify ri_allowed() David Hildenbrand
2017-08-18 15:52 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 04/18] target/s390x: simplify gs_allowed() David Hildenbrand
2017-08-18 15:59 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 05/18] target/s390x: no need to pass kvm_state to savevm_gtod handlers David Hildenbrand
2017-08-18 15:41 ` Thomas Huth
2017-08-18 11:43 ` David Hildenbrand [this message]
2017-08-18 16:04 ` [Qemu-devel] [PATCH v3 for-2.11 06/18] s390x/cpumodel: factor out determination of default model name Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of sysemu/kvm.h from some files David Hildenbrand
2017-08-18 16:08 ` Thomas Huth
2017-08-18 17:28 ` David Hildenbrand
2017-08-21 9:52 ` Cornelia Huck
2017-08-21 10:50 ` David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h David Hildenbrand
2017-08-18 16:11 ` Thomas Huth
2017-08-18 17:28 ` David Hildenbrand
2017-08-24 12:08 ` Cornelia Huck
2017-08-21 10:08 ` Cornelia Huck
2017-08-21 11:05 ` David Hildenbrand
2017-08-21 11:14 ` Cornelia Huck
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 09/18] target/s390x: move cc_name() to helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 10/18] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 11/18] target/s390x: move psw_key_valid() to mem_helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 12/18] target/s390x: move s390_do_cpu_reset() to diag.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 13/18] target/s390x: move get_per_in_range() to misc_helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 14/18] target/s390x: introduce internal.h David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 15/18] target/s390x: move a couple of functions to cpu.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 16/18] s390x: avoid calling kvm_ functions outside of target/s390x/ David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 17/18] s390x/kvm: move KVM declarations and stubs to separate files David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 18/18] target/s390x: cleanup cpu.h David Hildenbrand
2017-08-18 11:45 ` [Qemu-devel] [PATCH v3 for-2.11 00/18] " David Hildenbrand
2017-08-24 12:30 ` Cornelia Huck
2017-08-25 9:26 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818114353.13455-7-david@redhat.com \
--to=david@redhat.com \
--cc=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).