qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: qemu-devel@nongnu.org
Cc: rth@twiddle.net, agraf@suse.de, thuth@redhat.com,
	borntraeger@de.ibm.com, Cornelia Huck <cohuck@redhat.com>
Subject: [Qemu-devel] [PATCH v2 1/3] s390x/tcg: specification exception for unknown diag
Date: Fri, 18 Aug 2017 13:48:42 +0200	[thread overview]
Message-ID: <20170818114844.30061-2-cohuck@redhat.com> (raw)
In-Reply-To: <20170818114844.30061-1-cohuck@redhat.com>

While the PoP is silent on the issue, z/VM documentation states
that unknown diagnose codes trigger a specification exception.
We already do that when running with kvm, so change tcg to do so
as well.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 target/s390x/misc_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
index d23ffcd890..5a1eba02ab 100644
--- a/target/s390x/misc_helper.c
+++ b/target/s390x/misc_helper.c
@@ -109,7 +109,7 @@ void HELPER(diag)(CPUS390XState *env, uint32_t r1, uint32_t r3, uint32_t num)
     }
 
     if (r) {
-        program_interrupt(env, PGM_OPERATION, ILEN_AUTO);
+        program_interrupt(env, PGM_SPECIFICATION, ILEN_AUTO);
     }
 }
 
-- 
2.13.5

  reply	other threads:[~2017-08-18 11:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 11:48 [Qemu-devel] [PATCH v2 0/3] s390x: diag-related things Cornelia Huck
2017-08-18 11:48 ` Cornelia Huck [this message]
2017-08-18 11:51   ` [Qemu-devel] [PATCH v2 1/3] s390x/tcg: specification exception for unknown diag Thomas Huth
2017-08-18 11:48 ` [Qemu-devel] [PATCH v2 2/3] watchdog/wdt_diag288: Mark diag288 watchdog as non-hotpluggable Cornelia Huck
2017-08-18 14:51   ` David Hildenbrand
2017-08-18 11:48 ` [Qemu-devel] [PATCH v2 3/3] s390x: wire up diag288 in tcg Cornelia Huck
2017-08-18 11:52   ` Thomas Huth
2017-08-21 15:07 ` [Qemu-devel] [PATCH v2 0/3] s390x: diag-related things Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170818114844.30061-2-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).