Re: [Qemu-devel] [RFC v4 08/13] ide: enumerate_slots implementation

[Eduardo Habkost <ehabkost@redhat.com>]

On Wed, Aug 16, 2017 at 05:46:18PM -0400, John Snow wrote:
> 
> 
> On 08/14/2017 05:57 PM, Eduardo Habkost wrote:
> > Example output when using "-machine q35":
> > 
> >   {
> >     "available": true,
> >     "count": 1,
> >     "device-types": [
> >       "ide-device"
> >     ],
> >     "hotpluggable": false,
> >     "opts": [
> >       { "option": "unit", "values": 0 },
> >       { "option": "bus", "values": "ide.2" }
> >     ],
> >     "opts-complete": true
> >   }
> >   {
> >     "available": false,
> >     "count": 1,
> >     "device": "/machine/unattached/device[19]",
> >     "device-types": [
> >       "ide-device"
> >     ],
> >     "hotpluggable": false,
> >     "opts": [
> >       { "option": "unit", "values": 1 },
> >       { "option": "bus", "values": "ide.2" } ],
> >     "opts-complete": true
> >   }
> >   {
> >     "available": true,
> >     "count": 10,
> >     "device-types": [
> >       "ide-device"
> >     ],
> >     "hotpluggable": false,
> >     "opts": [
> >       { "option": "unit", "values": [ [ 0, 1 ] ] },
> 
> Hm, these unit values aren't really correct -- we do not support
> primary/secondary semantics for IDE buses on the AHCI device. I guess
> they technically exist, but you cannot use them for anything.
> 
> Should I do something to "disable" or otherwise hide the unusable
> secondary unit slots for AHCI devices?

If the device is already rejecting -device ...,unit=1, then the
bug is in my implementation of enumerate_devices.  Maybe it
should just look at IDEBus::max_units to find that out?

-- 
Eduardo