From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djibS-000233-Ja for qemu-devel@nongnu.org; Mon, 21 Aug 2017 05:02:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djibM-0006fJ-L1 for qemu-devel@nongnu.org; Mon, 21 Aug 2017 05:02:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41286) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1djibM-0006f0-CB for qemu-devel@nongnu.org; Mon, 21 Aug 2017 05:02:28 -0400 Date: Mon, 21 Aug 2017 11:02:22 +0200 From: Igor Mammedov Message-ID: <20170821110222.29d5c322@nial.brq.redhat.com> In-Reply-To: References: <20170817043102.6322-1-f4bug@amsat.org> <20170817172249.31cf5e3d@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/8] QOMify MIPS cpu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: Peter Maydell , Thomas Huth , James Hogan , Eduardo Habkost , qemu-devel@nongnu.org, =?UTF-8?B?SGVydsOp?= Poussineau , Yongbok Kim , Aurelien Jarno On Fri, 18 Aug 2017 17:08:29 -0300 Philippe Mathieu-Daud=C3=A9 wrote: > On 08/17/2017 12:22 PM, Igor Mammedov wrote: > > On Thu, 17 Aug 2017 01:30:54 -0300 > > Philippe Mathieu-Daud=C3=A9 wrote: =20 > [...] > >> Also I couldn't test it with KVM. =20 > > Tested in TCG mode (boots debian mips/mips64 kernel with different cpu = types), > > and new CPU leaf types show up on QOM tree as expected (QOMifycation is= done as expected) =20 >=20 > you mean the "info qom-tree" output? I've used scripts/qmp/qom-* scripts for testing which use QMP, but QOM tree that both use is the same so there shouldn't be any difference. >=20 > > and '-cpu help' also works as expected, > > so with checkpatch issues fixed you may add to patches my > >=20 > > Tested-by: Igor Mammedov =20 >=20 > ok thanks for the testing! >=20 > I'll wait to see if there is some KVM feedback from imgtec folks before=20 > spaming a v2. >=20 > >> Igor Mammedov (2): > >> mips: MIPSCPU model subclasses > >> mips: replace cpu_mips_init() with cpu_generic_init() > >> > >> Philippe Mathieu-Daud=C3=A9 (6): > >> mips: move hw/mips/cputimer.c to target/mips/ > >> mips: introduce internal.h and cleanup cpu.h > >> mips: split cpu_mips_realize_env() out of cpu_mips_init() > >> mips: call cpu_mips_realize_env() from mips_cpu_realizefn() > >> mips: now than MIPSCPU is QOMified, mark it abstract > >> mips: update mips_cpu_list() to use object_class_get_list() > >> > >> target/mips/cpu-qom.h | 1 + > >> target/mips/cpu.h | 357 +---------------= ------ > >> target/mips/internal.h | 422 ++++++++++++++++= ++++++++++ > >> hw/mips/cps.c | 2 +- > >> hw/mips/mips_fulong2e.c | 2 +- > >> hw/mips/mips_jazz.c | 2 +- > >> hw/mips/mips_malta.c | 2 +- > >> hw/mips/mips_mipssim.c | 2 +- > >> hw/mips/mips_r4k.c | 2 +- > >> hw/mips/cputimer.c =3D> target/mips/cp0_timer.c | 2 +- > >> target/mips/cpu.c | 57 +++- > >> target/mips/gdbstub.c | 1 + > >> target/mips/helper.c | 47 +++ > >> target/mips/kvm.c | 1 + > >> target/mips/machine.c | 1 + > >> target/mips/msa_helper.c | 1 + > >> target/mips/op_helper.c | 1 + > >> target/mips/translate.c | 23 +- > >> target/mips/translate_init.c | 68 +---- > >> hw/mips/Makefile.objs | 2 +- > >> target/mips/Makefile.objs | 2 +- > >> 21 files changed, 549 insertions(+), 449 deletions(-) > >> create mode 100644 target/mips/internal.h > >> rename hw/mips/cputimer.c =3D> target/mips/cp0_timer.c (99%) =20 >=20